nodewords_load_all_includes() does a file_scan_directory() to load. This is called via hook_preprocess_page() - which is run more or less every request to Drupal, the i/o from this can be a performance issue on some systems, especially given this is a fixed list that will only change when a new include is added. Attached patch changes this to just an array, otherwise logic should be the same.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | nodewords-n1115224-12.patch | 1 KB | damienmckenna |
| #8 | nodewords-n1115224-8.patch | 1.38 KB | damienmckenna |
| #4 | 115224_nodewords.patch | 1012 bytes | catch |
| #1 | 115224_nodewords.patch | 846 bytes | catch |
Comments
Comment #1
catchUploading the patch helps...
Comment #3
damienmckennaThanks Catch, will work on getting this included in the next release.
Comment #4
catchLooks like the checkout I was working from is out of date. Here's a patch (untested) that should apply to latest 6.x-1.x.
Comment #5
dave reidCommitted a modified version of the patch to Git that I tested myself: http://drupalcode.org/project/nodewords.git/commit/55909db
Thanks catch for profiling and reporting the performance bug!
Comment #7
damienmckennaNeeds to be re-rolled against the latest 6.x-1.x codebase.
Comment #8
damienmckennaI re-rolled catch's patch from #4 against the latest 6.x-1.x codebase.
Comment #9
dave reidThis has been re-applied.
Comment #11
damienmckennaNeeds to be re-rolled against 6.x-1.x.
Comment #12
damienmckennaRe-rolled and committed.