Where is this project going?

Hi,

I can give you a my personal roadmap for this module within the next 24 hours. However since I'm not officially a maintainer for this module (despite the fact that I've done the most work on it in the last months and also asked to become one) it won't be an official roadmap. This situation is also the reason why I created a seperate repository on github. It is a bit inconvient for you guys, but it allows me to work much quicker and more efficient on the module and its issues.

The last few weeks I had exams which is why its been a bit quite here ;-) (as far as qualified issue feedback goes). This is slowly going to change again.

There are currently 2 git branches which don't really work for me and a separate fork? at: https://github.com/Buesing-Sebastian/Drupal---Media-Browser-Plus, which does a lot! But also just isn't working jet. (Submitting multiple items on a media field for example).

Can you clarify a bit more what you mean by "Submitting multiple items on a media field for example". Maybe post some error messages or screenshots?

Greetings,
Sebastian

Hi,

Sebastian has been doing some awesome work on his github fork but this module suffered a bit recently from temporal insufficiency. Also called "lack of time". The maintainers of the module all work for Acquia on the Drupal Gardens project and we were in a major push for DrupalCon Chicago and our 1.0 release since December.

Now that those milestones have been hit, I at least, plan on putting a lot more time into this module. JacobSingh and effulgentsia I know have been pushing for more time to devote to the underlying media module on which this is built. I'm not totally sure if their gameplan for the near future includes work specific to media_browser_plus or not. As for myself, I would like to see this module improve near to the point of replacing the stock media browser in the media module.

I see this happening in two ways. By adding functionality and by adding organizational tools.

Functional

• Click and drag to select multiple files
• Selecting multiple files with shift or ctrl
• Searching media
• Contextual links and actions

Organizational

• Hierarchical taxonomy based organization e.g. "folders"
• Uploading or importing a file structure into a taxonomy hierarchy e.g. the directory tree in a zipped upload gets converted into the "folders" taxonomy
• Updating and applying taxonomies read from media files e.g. tags added to images
• Personal and public "folders"
• Shared "folders" either by user or role

Sebastian's work on github has already done a lot towards getting this module to where I would like to see it. I've updated the folders branch here and given Sebastian maintainer status so he can continue his work here in the issue queues.

So that is a quick rundown of where I see this module going. I think the more interesting question is where do you see the module going? Any help with the module would be appreciated. Anything from writing code, to suggesting features, testing patches, reporting bugs, writing documentation or "how to"s is a huge help towards getting excitement and energy behind moving the module forward.

subscribing and really good to see some progress.

I'm hoping that now that views is ready, we can re-work the folders / tags, etc fields to work with views.

Best,
Jacob

Subscribing - Thanks for the work you guys are doing!

Nothing has happened in this module recently. However, you may notice that the maintainers of this module are also maintainers of the media module this is built on top of. We've been working hard at stabilizing the media module and that is why there haven't been any commits to this project.

I personally have been near completely rewriting the implementation of the media browser. Especially focusing on the usage of iframes in the dialog popups. My goal is to remove some of the unneeded complexity so that others and myself can have an easier time extending the media browsing experience. Like within this module.

Hi,

first of apologizes for the long 24 hours. However I did say "I can" not "I will" ;-)...Anyway:
Let me comment on James list first:
Functional

• Click and drag to select multiple files:
  Nice feature but how would you differentiate between a user wanting to drag an image or select multiple?
• Selecting multiple files with shift or ctrl:
  Agreed. Shouldn't be to hard to implement
• Searching media:
  A very important issue and propably the one at the top of all feature request as far as I am concerned.
• Contextual links and actions:
  Do you mean a right-click menu for media items?

Organizational

• Hierarchical taxonomy based organization e.g. "folders":
  Done :-)
• Uploading or importing a file structure into a taxonomy hierarchy e.g. the directory tree in a zipped upload gets converted into the "folders" taxonomy:
  Good idea. Should be interesting to code :-)
• Updating and applying taxonomies read from media files e.g. tags added to images:
  Like meta data that is stored on images? Why not.
• Personal and public "folders":
  scroll a bit down.
• Shared "folders" either by user or role:
  same as above.

2 Things I would love too add here are (which would partially require changes to the media module too):

• physical folder structure:
  The taxonomy folder structure should represent a physical folder structure on the server. If a folder is renamed/removed the module should apply this to the physical data layer. If media files are moved they should be moved on the hard disk too.
  In Addition to that I would love to have a semi-automatic media import feature where you can just put media files in the folder structure on your hard disk and the mb+ module checks (via batch) if they exist in the DB and adds them when necessary. Also you would have a view where media items are displayed whose physical counterparts are missing with an overview where they might be used and if unused a possibility to delete them. This would be quite similiar to the media/import feature with the exception of the folder structure.
• media access rights:
  Similar to the node access system (http://api.drupal.org/api/drupal/modules--node--node.module/group/node_a...) I would love to see media items to be handled similiar. I already laid down some groundwork on this, but the current approach does not include an $operation parameter.
  Here we could also realise a public/private folder concept.

I would love some feedback on thoose two. Especially on what obstacles you may see.

Happy Easter!

Hmm. I guess I'm a little confused, as http://drupal.org/node/969010 makes it sound like all is well with MBP. I'm having issues with "folderizing" the initial import, and viewing the elements in the folders in thumbnail/grid view. In list view at admin/content/media/list, the initial import indicates that all media went to "Media Root", but clicking on the thumbnail button (admin/content/media/thumbnails), gives me a never ending throbber. See attached.

I guess I'm wondering what the real state of MBP is. This subfoldered media is absolutely necessary for my particular application. I'm also wondering why the fork on GIT hasn't been turned into a 7.x-*-dev release? If there's work to be done, I'll gladly get involved.

Hi mpgeek,

please create a new issue and in this issue add some information as to what firebug (or any simliar debug tool) tells you is returned from the AJAX request. If you use FB then you can just look into the console and it tells you what request went out and what data did come back (if any) so we can determine the source of your problem.

I'm also wondering why the fork on GIT hasn't been turned into a 7.x-*-dev release? If there's work to be done, I'll gladly get involved.

This will be done shortly via small patches to the main fork with each patch adding small features so we can be certain everything that is added is top quality ;-)

For completeness to future troubleshooters, the issue is here: http://drupal.org/node/1139210

I am using the latest Media Module version with the latest install/un-intall patch as of a few days ago here:

http://drupal.org/node/970696#comment-4407894

When installing this module I get this error:

An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /batch?id=331&op=do StatusText: Service unavailable (with message) ResponseText: EntityFieldQueryException: Entity <em class="placeholder">media</em> has no base table. in EntityFieldQuery->propertyQuery() (line 1066 of /Users/nituk/Sites/drupal7/includes/entity.inc).

It gives me the option to "continue to the error page", which after clicking simply returns me to the modules page and I get an "error media batch"

That version of Media is going to be incompatible with the current media_browser_plus. The media module has undergone some significant architecture changes and media entities no longer exist. Instead file entities are being included as a sub module of media. This module is going to need to be refactored to handle the changes.

I didn't post for review (shame on me). But I just pushed this which I think makes it work again.

http://drupalcode.org/project/media_browser_plus.git/commit/f0ca14a0e7ae...

Thanks.

Updated the latest versions it doesn't show errors but it doesn't show the folders, in fact it is like media browser plus is not active.
using your latest commit and the latest dev version of Media

Use the folders branch from here...
http://drupal.org/project/media_browser_plus/git-instructions

Then use this patch (#7) if you want to use the latest dev version of Media...
http://drupal.org/node/1139210

Don't need to use the patch if you are using the stable Media release.

I had to change some more stuff to get the folders branch running with the newest media module

discipolo
after this path I also got next error when try install the Media browser plus module

An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /?q=batch&id=11&op=do StatusText: error ResponseText: Recoverable fatal error: Argument 1 passed to drupal_array_get_nested_value() must be an array, null given, .....

ps. I have some already uploaded files, using the Media module dev

hm, for fix it need in file media_browser_plus.admin.inc in line ~39 change this:

media_save($media); 

to this:

file_save($media); 

And also for fix upload I litle change function media_browser_plus_submit in media_browser_plus.module file.
In patch was:

$media_entities = file_load_multiple($fids);

I change to this

if (!is_array($fids)) {
   $media_entities = media_multi_load($fids);
} else{
   $media_entities = file_load_multiple($fids);
}

thats weird. could be that i forgot something, have it working on one site but cannot replicate it. here is another patch with one more line changed
also i changed the line 39 in admin.inc to read file_save($media); this is not yet in the patch.

very nice! I just figured out that it was only working when i have plupload installed. comment #22 & 23 should take care of this!
here is everything put together (i hope)

but I still got error when open "Library Plus" (media/browser), look in attached file
I think it some problem in the media_browser_plus_load_multiple function, but I cannot find... it something after

...
if($params['paging'] && !$params['count_only']){
...

and before

...
if($params['count_only']) {
...

full error text:

 <em class="placeholder">PDOException</em>: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near &#039;)) AND (field_data_field_folder0.entity_type = &#039;file&#039;) ) subquery&#039; at line 2: SELECT COUNT(*) AS expression
FROM 
(SELECT 1 AS expression
FROM 
{field_data_field_folder} field_data_field_folder0
INNER JOIN {file_managed} file_managed ON file_managed.fid = field_data_field_folder0.entity_id
WHERE  (field_data_field_folder0.field_folder_tid IN  (:db_condition_placeholder_0)) AND (field_data_field_folder0.deleted = :db_condition_placeholder_1) AND (file_managed.type IN  ()) AND (field_data_field_folder0.entity_type = :db_condition_placeholder_2) ) subquery; Array
(
    [:db_condition_placeholder_0] =&gt; 1
    [:db_condition_placeholder_1] =&gt; 0
    [:db_condition_placeholder_2] =&gt; file
)
 in <em class="placeholder">field_sql_storage_field_storage_query()</em> (line <em class="placeholder">568</em> of <em class="placeholder">/media/sites/localsite/drupal/modules/field/modules/field_sql_storage/field_sql_storage.module</em>).
 

And I can reproduce it if go link like next
http://example.com/?q=admin/content/media/thumbnailsJSON&folder=folder_load_1&page=0&filter=%5B%7B%22property%22%3A%5B%22type%22%2C%5B%5D%2C%22IN%22%5D%7D%5D

ah, okey ... all works if I open Library Plus when I add/edit content :)

so you are saying it only works via the field for you? and not via admin/content?

yes, works via field and admin/content ...
but when I tried open directly /?q=media/browser ( for test :) ) it not works, but without MediaBrowserPlus it works
here is something with 'filter' ...

now I think it not big problem ;)

so does this need review? or work?

Hello when I try to access folders; in Library it doesn't display files only a tree of folders, plz help applied patch 24

Hi, i'm using media-1.0-beta5 and media_browser_plus from the folders brach from git on d.o. I have applied the #24 patch and now I'm having these errors:

   * Notice: Trying to get property of non-object in _media_browser_plus_folder_list() (line 1060 in media_browser_plus.module).
   * Notice: Trying to get property of non-object in media_browser_plus_grid_view_form() (line 1658 inmedia_browser_plus.module).
    * Notice: Trying to get property of non-object in _media_browser_plus_folder_list() (line 1060 in media_browser_plus.module).

When i click Library Plus tab, don't load anything neither. I have tried with and without the plupload module enabled (as mentioned before) and i'm having the same results.
I'm not sure if i'm missing something when i apply the patch.

Media module 7.x-2.x have started the work with replacing the media browser with a view (Views). This allow us do filter, sort, etc, without having to roll that sort of functionality our self. My question where does that leave this module?

Write the following instead of "$conditions = $filter;" in your media_browser_plus_thumbnailsJSON(). Maybe sb can put this into a patch?

// bugfix - $conditions = $filter;
      foreach($filter as $key => $value) {
        // checking each filter
        $valid = true;
        foreach($value as $type => $params) {
          foreach($params as $param) {
            if(strlen(trim($param)) == 0) {
              $valid = false;
              break;
            }
          }  
        }
        if($valid)
          $conditions[] = $value;
      }

Yeah it is interesting changes. I'm not saying this project is not useful, I'm just trying to make sure that most one know where the media module is heading. Regarding the multi-value field, it is indeed important, but there is also changes at the fields level in Media #1201936: Move the media field to a non-required submodule.

I've installed this and media (7.x-2.x-dev). I still get the "normal" media upload popup. What am I doing wrong?

Subscribe.

Just letting you know that i am working on physical folder structure part of #10 and i am confident that it will be ready in the next days

It is ready and it is on github https://github.com/Buesing-Sebastian/Drupal---Media-Browser-Plus

Thanx for the update @rootatwc :) Could you enlighten me to what version of http://drupal.org/project/media it works? We currently have 4 different current "releases" of the Media module, and that confuses me somehow ;)

i have it tested with 7.x-1.0-beta5 but it seems to work with 7.x-2.0-unstable1 too after a quick check

about "working with physical folder structure" ... whay you use a "media" folder instead of default that in "public://", and whay this module tried move all media files (physical) in to this folder after instaling... it very bad idea when I alredy have loot of files, and when some files alredy in other folders...
maybe better use default folder "public://", and disable auto moving?

subscribe

Submitting multiple items on a media field for example

This feature request could be certainly adressed with this new Image widget Mupload !

Mupload provides a file field (and image field) widget that wraps
a Plupload form element. This means multiple file uploads across
a wide range of browsers. It even supports drag-and-drop.

For a file field (or image field) use the Muploader widget instead of
the default File (or Image) widget.

This module is for Drupal 7 only!

http://drupal.org/sandbox/vingborg/1138512

Your version @rootatwc seems to be very cool, but I have a few bugs wenn I try move the file from one location to another.
When I do it, I get every time the following message:

Notice: Trying to get property of non-object in media_browser_plus_construct_dir_path() (line 2160 of /kunden/.../sites/all/modules/media_browser_plus/media_browser_plus.module).
    The specified file public://media/testfolder-01/produkt2.jpg could not be moved, because the destination is invalid. More information is available in the system log.

The Drupal log message says the following:

File public://media/testfolder-01/produkt2.jpg (/.../sites/default/files/media/testfolder-01/produkt2.jpg) could not be moved, because the destination public:/produkt2.jpg is invalid. This may be caused by improper use of file_move() or a missing stream wrapper.

I think there is something wrong with

function media_browser_plus_construct_dir_path($term) {
  $parents = array_reverse(taxonomy_get_parents_all($term->tid));
  $path = variable_get('file_default_scheme', 'public') . '://';
  foreach ($parents as $parent) {
    $path .= $parent->name . '/';
  }
  $path = str_replace('Media Root', variable_get('media_root_folder', 'media'), $path);
  return rtrim($path, '/');
}

Maybe something like this would be better:

function media_browser_plus_construct_dir_path($term) {
  $file_default_scheme = variable_get('file_default_scheme', 'public') . '://';
	$path = $file_default_scheme;
  $parents = array_reverse(taxonomy_get_parents_all($term->tid));
  foreach ($parents as $parent) {
    $path .= $parent->name . '/';
  }
  $path = str_replace('Media Root', variable_get('media_root_folder', 'media'), $path);
  $tpath = ($path != $file_default_scheme) ? rtrim($path, '/') : $path;
  return $tpath;
}

ah i see!
seems i never run on this bug since i only use files inside the media root folder:)

i will create a patch and send it to sebastian thanks:)

I have to thank YOU and sebastian for your work :)

Here is the patch against 7.x-1.x

Reviewed and committed!

This was not committed to 7.x-1.x branch.

indeed.that commit was for github branch

actually i just checked,its both in 7.x-1.x and 7.x-2.x