Closed (fixed)
Project:
Panels
Version:
7.x-3.0-alpha3
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Apr 2011 at 14:06 UTC
Updated:
4 Apr 2013 at 16:12 UTC
Jump to comment: Most recent file
Comments
Comment #1
FreeFox commentedI have the same problem :(
Comment #2
lifepillar commentedSame problem here, using Drupal 7.2, PHP 5.3.6 and PostgreSQL 9.0.4.
To reproduce, visit admin/structure/stylizer/add and simply fill out the forms as follows:
1) write a title and a description, and click Continue;
2) choose “Panel pane” from the pull-down menu, and click Continue;
3) choose the “Plain” basic style, and click Continue;
4) click on Finish.
The warning appears after clicking on Finish. The bug does /not/ occur if the chosen type is “Panel region” or if the basic style is “Rounded shadow box”.
Comment #3
lifepillar commentedJust forgot to mention that the style is created anyway, and subsequent modifications seem to be saved correctly (although the warning appears also upon editing an existing style).
Comment #4
ouyang1512 commentedSame problem here. Anyone knows what's wrong here? Thanks!
Comment #5
chsoney commentedThose three lines used coding conventions which assume a variable was an object. I am not sure if it is a problem that the variable is not an object, but this patch should get rid of the warnings.
Comment #6
chsoney commentedLooking more closely at the code and where this code is called, this patch appears more appropriate.
Comment #7
chsoney commentedLet's try this one last time. Number 6 breaks the view of a panel page because there is no consistency between the use of theme variables. Based on this section of panels_theme:
The variable that they use throughout the mosule ($content) is not part of the panel_pane theme. But $output is only used in panels_stylizer_pane_preview. This time, I changed output to content since that seems to be what every other page uses.
Comment #8
topdawg commentedThank you very much for the patch, it worked.
Comment #9
merlinofchaos commentedCommitted and pushed! THanks!
Comment #11
globexplorer commentedNotice: Trying to get property of non-object in fieldable_panels_panes_preprocess_panels_pane(). The only reason for this error is the lack of an conditional statement including an is_object
This produces the error:
This avoids the error:
Comment #12
globexplorer commentedComment #13
globexplorer commentedTo avoid erros like these always add a conditional statement:
or for arrays
Comment #14
merlinofchaos commentedThis is an issue about the Panels module. You're talking about code in the fieldable_panels_pane module.
Returning to previous status.