'Reason for payment: order number 0' is displayed on the checkout screen if no order number exist yet - and the 'Display reason for payment...' option is selected in the payment settings for uc_bank_transfer.

My suggestion is to not show this field if the value of $oid == 0 in uc_bank_transfer_bank_details() and I have attached the patch to accomplish just this.

Alternatively it could say something like to use you order number once generated but it sounds a bit confusing??

CommentFileSizeAuthor
uc_bank_transfer.patch769 bytesdaniel bornman

Comments

xibun’s picture

xibun commented

this was an issue in Ubercart 2/Drupal 6... I thought it was fixed in Ubercart 3 by assigning the order number earlier.. so I removed the logic which was hiding the order number on checkout page..

I will try again to reproduce it in my installation.. do you always have the issue? or only when following a special sequence?

daniel bornman’s picture

daniel bornman commented

I thought it never used to that on my Drupal 6 sites...

You should get it whenever viewing checkout straight after the cart (without the checkout validation having been run). Thanks.

xibun’s picture

xibun commented

just updated to the latest Ubercart .dev version. I still cannot reproduce the problem in Ubercart 3.. I always do have an order id assigned in checkout. actually reloading the checkout page increments the order number in my installation... so maybe it is coming from checkout validation being run - but what might trigger that validation?

xibun’s picture

xibun commented

I now can reproduce the problem: when I have bank transfer as the only active payment method. but as soon as I add another method the order numbers are set (and incremented on reload).

@danielbornman: do you have other payment methods active? if yes: which one(s)?

feras’s picture

feras commented

I found the same problem. It gives me 0, when bank transfer is placed as default payment method (first in list). If I change order of methods, then when I select "Bank transfer" it gives correct number.

daniel bornman’s picture

daniel bornman commented

@xibun: I only use bank transfer at the moment which coincides with what you (& feras) dicovered...

xibun’s picture

xibun commented
Status: Needs review » Postponed (maintainer needs more info)

@danielbornman & @feras: thanks for your feedback on this. I have created a related issue on Ubercart #1120776: order number increments on reload checkout page. my plan is to wait for that one being out of the way before deciding how to patch things here.

xibun’s picture

xibun commented

we now have a fix for #1120776: order number increments on reload checkout page - but the order number is still 0 at first. before fixing it here I wait to see how #1285938: Create order on initial checkout turns out (patch 1 in that issue thread would make this issue obsolete).

xibun’s picture

xibun commented
Status: Postponed (maintainer needs more info) » Needs review

#1285938: Create order on initial checkout was just committed to the dev version. to me now this issue is solved and can be labelled "closed (works as designed)".

xibun’s picture

xibun commented
Status: Needs review » Fixed

just tested it myself with latest Ubercart version. the issue is fixed with the changes introduced on Ubercart side.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.