5.0 compatible?
wuziq - January 22, 2007 - 10:13
| Project: | Import Typepad / MoveableType |
| Version: | HEAD |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Tried using this with Drupal v5.0 and it does not appear on the Modules list.
I tried hacking together a .info file and putting it in the same folder so that it would at least appear on the Modules list, but once I enabled it and selected "type pad" (which was listed under Administer instead of Content), I got this message (which probably doesn't mean a whole lot anyway):
warning: call_user_func_array() [function.call-user-func-array]: First argumented is expected to be a valid callback, 'typepad_step1' was given in /home/wuziq3d/public_html/drupal/includes/form.inc on line 217.
#1
I currently need to implement a few more features in 4.7, then I'll consider migrating it to 5.0, unless someone does it first. Give it at least a few weeks before this activity.
#2
I'm tempted to help out with this, as I could do with it too. If you still have updates to put in, it may be best to wait until after you've done that though.
#3
Hi there,
Just a quick note to say that I too would be keen to see this module ported to Drupal 5.
Many thanks,
Jack
#4
I need this module compatible with 5.1 for a Client, I am planning to start development on it starting next week (04/02/07).
Please provide any updates you have regarding this.
Thanks,
Justy
#5
That's excellent news - thanks.
#6
I've ported this module to 5.0; here is a patch for review. It's worked great for me, but I have not tested it thoroughly.
#7
I've applied this patch and it works for me too - very good work.
Attached is a .info file (I've had to call the file import_typepad.info.txt becuase drupal.org wont allow me to upload a .info file - please rename this file import_typepad.info to use it).
#8
awesome.. worked for me as well.
#9
awesome work, could you be so kind as to try to apply this to the current 4-x version? there has been some minor changes
#10
subscribe
#11
Patch for the 5.0 version applies cleanly on HEAD. Import functions fine, on content, user mapping and category mapping.
Great work!
RTBC IMO
#12
After complete
"Attached is a .info file (I've had to call the file import_typepad.info.txt becuase drupal.org wont allow me to upload a .info file - please rename this file import_typepad.info to use it)."
i got this message .
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'typepad_step1'
wht can i do ?
#13
After configuring everything i got this result
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'typepad_step1' was given in includes\form.inc on line 218.
================So ple let me know wht should i do ?
#14
Applied to HEAD cleanly and worked for me, although I found a few minor bugs and fixed them.
1) Comment URL's were being imported with an extra space at the beginning, causing some problems, so I added a trim.
2) A format_plural needed some tweaking.
#15
I also did a quick upgrade to get this working for Drupal 6. It's working for me, but the module overall could definitely use a clean-up job.
#16
Oops, I left a print statement in.
#17
Heya, just tried your patch against HEAD, 4.x and 5.x releases (tarball soon) but im getting failures
dgtlmoon@nine:~/workspace/drupal.org-cvs/contributions/modules/import_typepad$ cat import_typepad_60_1.patch|patch -p0patching file import_typepad.module
Hunk #1 FAILED at 12.
Hunk #2 FAILED at 37.
Hunk #3 succeeded at 81 (offset -1 lines).
Hunk #4 FAILED at 97.
Hunk #5 FAILED at 107.
Hunk #6 FAILED at 131.
Hunk #7 FAILED at 168.
Hunk #8 FAILED at 189.
Hunk #9 FAILED at 269.
Hunk #10 FAILED at 348.
Hunk #11 succeeded at 408 (offset 23 lines).
Hunk #12 succeeded at 459 (offset 30 lines).
Hunk #13 FAILED at 485.
Hunk #14 FAILED at 519.
11 out of 14 hunks FAILED -- saving rejects to file import_typepad.module.rej
which release did you patch against?
#18
Both of them are patched against HEAD. I just tried it out again on a fresh checkout:
cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -r HEAD -d import_typepad contributions/modules/import_typepad
Both import_typepad_50_1.patch and import_typepad_60_1.patch applied cleanly to that checkout.
#19
yes that is compatible
#20
thanks for all the feedback! i've rolled 5.x and 6.x releases
#21
he import-typepad version I downloaded from Drupal.org today for 6.x includes the $may_cache argument for import_typepad_menu, you should remove this as it is no longer used by the menu system. it won't work as-is, here is a 6.x-compatible version:
<?php
function import_typepad_menu() {
$links = array();
$links['admin/node/import_typepad'] = array(
'title' => 'type pad',
'page callback' => 'import_typepad_page',
'weight' => 5,
'access argument' => array('import nodes')
);
$links['admin/node/import_typepad/preview'] = array(
'title' => 'type pad',
'page callback' => 'import_typepad_preview',
'weight' => 5,
'access arguments' => array('import nodes'),
'type' => MENU_CALLBACK
);
}
?>
#22
Automatically closed -- issue fixed for two weeks with no activity.