I'm a full time Drupal developer and would like to contribute back modules I develop for client sites.
I have developed a Drupal 7 module called Node CSS based on the work I did for www.nowmusic.com to allow custom backgrounds to be managed through the CMS:
http://www.nowmusic.com/bundles/now-thats-what-i-call-no-1s
http://www.nowmusic.com/bundles/now-thats-what-i-call-80s
I have created a sandbox project at: http://drupal.org/sandbox/xalen/1079842
It essentially allows values from fields in a node to be used in a CSS template.
There are other CSS modules but these are simply for including manually written CSS from a single field: http://drupal.org/project/css, http://drupal.org/project/css_injector. My module uses a CSS template instead and injects data from fields into the template therefore allowing end users to easily change node background colours and images etc.
Another module I plan to create is a file icon manager. There is http://drupal.org/project/icon which I would take over since it doesn't appear to be actively maintained.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | node_css-n1116706.patch | 14.9 KB | damienmckenna |
Comments
Comment #1
damienmckennaNice module idea, I'll take a look at this tomorrow.
Comment #2
damienmckennaReviewing the code there are minor code formatting tweaks that could be made, e.g.:
A few other suggestions:
Take a look at the attached patch, it cleans up most of the coding standards issues.
Comment #3
oliverpolden commentedThanks Damien. I went through the patch manually rather than applying it so I could see where I went wrong. I had used the coder module, did you use the grammar parser for some of that?
Fixed code formatting etc. and committed.
Validation and README.txt todo
Comment #4
oliverpolden commentedI've added a README.txt file, fixed a couple of bugs and added validation to check the template files exist.
Comment #5
damienmckennaGood stuff, getting very close. A few items:
Comment #6
damienmckennaI think this is very good with the improvements, takes a different approach than the current CSS module and only has small issues remaining (besides a v2-worthy expansion of functionality). I'd like to see a response from @xalan regarding plans for the module's future vs naming convention (see my comment #5 above) but otherwise this is good & worth approving.
Comment #7
oliverpolden commentedHi Damien,
Yes I had considered calling it Entity CSS. The main reason I called it Node CSS was because it runs off hook_node_insert and hook_node_update, plus I'm not familiar with entities (yet). Naming it Entity CSS could be misleading as it wouldn't work with other types of entities in its current state.
I guess it's best to name it Entity CSS now and I can always put notes in the module text explaining it doesn't work with entities yet, would probably get patches from others for that! It would be great to have this working with users and taxonomies etc. It would be really powerful, haha I'm really quite excited!
I'll change the module name and get it updated shortly.
P.s. It's xalen ;-)
Comment #8
damienmckennaAny further progress on this?
Comment #9
klausiNo activity in several months. Reopen and set the status to "needs review" if you are still pursuing this application.