Active
Project:
Fancy
Version:
5.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Jan 2007 at 16:38 UTC
Updated:
9 Apr 2007 at 17:53 UTC
Because of print theme('navlinks', $primary_links); primary links don't show.
Changing the 'navlinks' to 'links' works but site looks a bit strange. (Thanks a lot for this theme)
Comments
Comment #1
yngens commentedI confirm this error.
Comment #2
jgarabot commentedIn I explorer 7 shows only 2 primary links, the first two applied. In firefox they show ok.
Comment #3
he_who_shall_not_be_named commentedChanged title back. Are you sure that you tested the 5.x-1.x-dev version?
Comment #4
sangamreddi commentedHi all,
Thanks. back after long time, still the problem exists?
For me its working fine under IE and firefox http://www.sandeepone.com/
I tried on new install and its working well.
Comment #5
yngens commentedI guess http://www.sandeepone.com is not 5.X. In Drupal 5.X they changed the way the links are cerated. Which makes it is not possible to theme every button separately. All the buttons look alike.
Comment #6
yngens commentedThis one is a duplicate thread http://drupal.org/node/118757
Comment #7
ricmadeira commentedJust installed the 5.x version and got this bug too.
Comment #8
ricmadeira commentedAnd you can theme the buttons separately. It's just that the CSS ids/classes seem to have changed.
Example:
id="primary-link-1" is now class="first menu-1-1-650"
id="primary-link-2" is now class="first menu-1-2-650"
id="primary-link-3" is now class="first menu-1-3-650"
So we just have to change the .css file. Right guys?
Comment #9
ricmadeira commentedAnother issue is the CSS id/class of the active/current button. We used to have a fixed id for each button, and a "current" class for the active button. Now we have no ids, only a class for each button and it so happens that that class changes when the button is active.
The HTML used to be like:
And is now:
I've been trying to rebuild the CSS code for the new tags, but I can't seem to get the active buttons right, among a couple other small things (the hover effect on links). Can we get a CSS wizard in here? Thanks! :)
Comment #10
ricmadeira commented[Oops, sorry. I meant to write it like this.]
The HTML used to be like:
<li class="current" id="primary-link-2"> <a href="/aggregator" class="active" rel="nofollow">And is now:
<li class="menu-1-2-650-active"> <a href="/aggregator" class="menu-1-2-650-active active" rel="nofollow">Comment #11
ricmadeira commented[Damn... can't seem to get anything right tonight. Just wanted to let you know that those rel="nofollow" tags don't belong there; they were added by Drupal's tag filter when I mistakenly posted my code without using the proper < code> and < /code> tags. Sorry.]
Comment #12
yngens commentedRicmadera, I hope so. That we need just to change classes. It would be great if anyone could successfully theme primary buttons. I could not, so my button's are all of the same color.
Comment #13
charles.thompson commentedI've looked at the code and I can't figure it out either. I renamed the tags as someone suggested earlier, but that didn't color the tabs. I can color them all one color, but that is all I can get out of it. Has this bug really been open this long?
Thanks...
Comment #14
gurukripa commentedany update on this theme for 5.1 ?
someone pls do something to help us..else the top of the theme looks horrible :(
Comment #15
xDaveN commentedagreed. Waiting patiently on our end too. If I knew the code, I'd help.
Comment #16
gurukripa commentedhi guys..i managed some things on my site..by playing around with the style.css file and template.php
also have a look at page.tpl.php
you can tweak the colors...and then things will look alright..
actually what has happened in the original files is that it accomodates about 10 primary tabs...but some colors chosen are of the lighter kind...and when we get to the right...there is no such file....
you could even decide to change the image files ...to colors of ur choice...
however remember to back up the original settings..and tweak one color at a time..
i have no knowledge of css or php..but if u give it a close look..you may be able to figure it out..and keep a color code index handy..use google to search for html codes..
all the best.
Comment #17
yngens commentedgurukripa, why don't you post your modifications of style.css file and template.php?
Comment #18
gurukripa commentedin the style.css file pls see that there are only a few color blocks..that have been made initially..if u have more tabs..then u shld add like this
#primary-tabs li#primary-link-9 {
float:left;
background:url("images/left1.gif") no-repeat left top;
margin:0;
padding:0 0 0 9px;
}
#primary-tabs .current#primary-link-9 {
background-image:url("images/left_on.gif");
}
#primary-link-9 a {
float:left;
display:block;
background:url("images/right1.gif") no-repeat right top;
padding:5px 15px 4px 6px;
text-decoration:none;
font-weight:bold;
color:#fff;
margin-right:2px;
}
this shld take care of things..and maybe a little more tweaking...i cant remember all of it now..all the best..will try to look up more if u havent been able to do it yet..
template.php i think can be left alone.
i am currently helping out someone with a philosophy site..and did this for that..
u can have a look at it www.go2tirupati.com/caitanya and maybe join up if u like it :)
Comment #19
yngens commentedgurukripa, you just copied the code from the original css file. that does not work.
Comment #20
ricmadeira commentedYeah, I think he's talking about adding more colored tabs to the 4.7 version... not correcting the CSS in the 5.1 version!
Comment #21
jbartek commentedI'm using 5.1 and I followed instructions from http://drupal.org/node/118757 and the tabs are now in color! You just need to download http://cvs.drupal.org/viewcvs/*checkout*/drupal/contributions/themes/fan... and save it into your .../themes/fancy directory.