Warning when selecting Entity bundle -> Filter Criteria

Chasing this down all day...
From what I conclude in comparing Content->Article vs my BIR Object-> Bir Image, the views handler used is based on the field type from the table data:

File: views.module Line: 987

function views_get_handler($table, $field, $key, $override = NULL) {
  static $recursion_protection = array();

  $data = views_fetch_data($table, FALSE);
  $handler = NULL;
.....
   if ($handler) {
    return $handler;
  }
......
}

Because my entity bundles are defined by the "type" column, it returns:

[type] => Array
  (
    [filter] => Array
      (
        [handler] => views_handler_filter_string
      )
  )

Thus, it is using the views_handler_filter_string vs views_handler_filter_node_type.

The error occurs when File: admin.inc, Line 2146 runs:

$description = $handler->admin_summary();

File: views_handler_filter_string.inc, Line: 133

function admin_summary() {
  if (!empty($this->options['exposed'])) {
    return t('exposed');
  }

  $options = $this->operator_options('short');
  $output = '';
  if(!empty($options[$this->operator])) {
    $output = check_plain($options[$this->operator]);
  }
  if (in_array($this->operator, $this->operator_values(1))) {
    $output .= ' ' . check_plain($this->value);
  }
  return $output;
}

$this->value is an array in this circumstance: array('bir_image' => 'bir_image'). It's an array in other cases too from what I can tell: array('article' => 'article'). It's just handled differently in the other filters. Changing $this->value to a string fixes the warning, as well as showing the bundle in the Filter correctly: BIR Object: Type (= bir_image)

I'm not offering a fix as I'm not sure how this should be handled. Whether it should be taken care of in the admin_summary() code or some other place.

This is simply running the with Entity API, which is suppose to have built in Views operation.

You asked about how the array gets in there. There is not a text field, it's a drop down. It's like I explained above...
The entity info and table stores the bundle types in a column named "type."

.....
'entity keys' => array(
  'id' => 'oid',
  'bundle' => 'type',
   'label' => 'label',
),
.........

.........
'type' => array(
  'description' => '{bir_object} type.',
  'type' => 'varchar',
  'length' => '255',
  'not null' => TRUE,
),
........

When creating a new View, the file views.module Line: 987 function runs, it's selecting the "type" column to display in the drop down so the appropriate bundle types appear.
Show [BIR Object] of type [BIR Image]
(see image attached)

Since the column "type" is a string, the function returns views_handler_filter_string as I commented above.

Now if I have to solve this by creating my own views data handler for my entity bundles, I will. I simply thought an entity is an entity, and the bundle types would be handled appropriately.

@dereine
Sorry, just saw this.
Thanks. I will check it out tomorrow. It's 12am here and my eyes and brain are fried :-)

@dereine
I tested the patch and it appears to work.

I changed how I was doing things in my own modules (nodes instead of entities), but tested the result using Organic Groups. When creating a view and choosing:
Show: Organic groups membership of type og_membership_type_default
It produced the same error I had with my entities. Once I applied the patch, it worked as expected with no errors.

What issue should be created for entity api? I'm not sure how the issue would be phrased, or where the problem would be in entity api.

Thanks for this patch.

Not sure what you mean... but every example I've come across using bundles has had a type table like node. For example, the same error occurs when using the Profile2 and OG.

So yes, I guess your statement about the handler Entity API is using should be changed.

Thanks dereine. Didn't even check how it effected other modules.

Sorry. The patch did work for me if that is what you are asking.
Kind a new to Drupal so not sure if there is something more I need to do for testing.