Closed (duplicate)
Project:
HTML Mail
Version:
6.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Apr 2011 at 06:52 UTC
Updated:
20 Jun 2011 at 08:15 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bailsbails commentedLikewise, rolled back to previous version!
Comment #2
Nosfe commentedSame here. rolled back too.
Comment #3
pillarsdotnet commentedFixed in 6.x-2.4 -- sorry. Been a lot of rapid changes these past couple of days while I was consolidating the 6.x and 7.x branches.
Comment #4
Tino commentedThanks, but still having the same error message.
Now in line 19...
Comment #5
Rob_Feature commentedSame here
Comment #6
pillarsdotnet commentedWhat version of the Mail MIME and Mail System modules are you using?
Comment #7
virtuali1151 commentedsame here... in the latest dev version:
PHP Fatal error: Interface 'MailSystemInterface' not found in /home/site/public_html/sites/all/modules/htmlmail/htmlmail.mail.inc on line 19
Comment #8
pillarsdotnet commentedTry this patch, or grab the latest dev version (updating now.)
Comment #9
jimmyobomsawin commentedSame error. Seems that the 2.x version adds dependencies that weren't there before. I deleted the htmlmail folder so I could access the site again, installed and enabled Mail System, Mail MIME, and Echo, then installed and enabled htmlmail. Everything is back to normal.
Comment #10
pillarsdotnet commentedOkay, I need to add an update hook that prints an intelligent error message if someone updates from 6x.-1.x to 6.x-2.x and doesn't install prerequisites.
Comment #11
Tino commentedNot using Mail MIME or Mail System at all...
Comment #12
pillarsdotnet commentedFixed in 6.x-2.5. If you upgrade from 6.x-1.x to 6.x-2.x without first installing and enabling dependencies, HTML Mail will warn about the missing dependencies, disable itself, and redirect to the module page.
Comment #13
pillarsdotnet commentedVersion bump. 6.x-2.5 had a syntax error, sigh.
Comment #14
Vc Developer commentedSame here! rolled back to htmlmail 6.x-1.7......
Comment #15
pillarsdotnet commentedComment #16
pillarsdotnet commentedComment #17
Ela commented.. why all the new dependencies? 1.7 version was working fine?
Comment #18
pillarsdotnet commentedThe dependencies in the 2.x branch provide features and flexibility lacking in the 1.x branch:
(39 lines)(261 lines)emogrifier.phpfile. This is the currently-recommended way to handle such dependencies.(281 lines)(379 lines)All of the above helps distinguish HTML Mail from the competition.
Comment #19
pillarsdotnet commentedAnother version bump.
Comment #20
jddeli commentedThis is not working.
Comment #21
pillarsdotnet commentedjddell -- you'll have to be a bit more specific, if you want my help fixing things.
Comment #22
Anonymous (not verified) commentedWhy exactly was the 2.x branch marked as a security update from 1.x? When attempting to upgrade there is a very different setup and process for implementing HTML email than the 1.x branch. The module was rewritten it looks like and we're basically being "forced" to upgrade because it's flagged as a security update.
Is this an error or just really poor development choice?
Comment #23
Rob_Feature commented#22: My question exactly. It seems that a security release was chosen simply to force people to upgrade to 2.x. If so, that's a really bad idea.
Comment #24
Tino commented+1 #22. The module simply does exactly what I want it to do. If for security reasons it is not necessary to upgrade and to install additional modules I am not familiar with, I'd rather leave it as was. The less modules, the better I'd say. Less (maintanance) work as well... Maybe the 1.x-branch can stay "alive" without dependencies?
Comment #25
pillarsdotnet commentedI don't know where this "security release" idea is coming from.
It's just that I'm not willing to support the 6.x-1.x/7.x-1.x branches any longer, so I unchecked their "Supported" checkbox on the project's "Administer releases" page.
Comment #26
Ela commented+1
Comment #27
sterndata commentedThis is REALLY DISRUPTIVE update. It should have nicely converted my existing template, but that's gone. After reverting, I get dire warnings from Drupal about using unsupported modules.
Comment #28
pillarsdotnet commentedI'm sorry about the "dire warnings", but you can always disable the update module if they bother you that much.
The 6.x-1.x branch has been unsupported for quite some time, really. Neither Chris Herberte nor I want to support it. If you want to support it, ask for maintainer access.
I can always fork the 6.x-2.x/7.x-2.x branch off to a separate module.
On a separate note, I don't see how it's possible for a module upgrade to rewrite your template files. Can you point me to an example of another module that rewrites template files? i'd like to look at the code.
Comment #29
Tino commentedIf 6.x-1.x is a safe module that doesn't need updating for security reasons, I would really appreciate a seperate branch for 2.x. Then all websites with 1.x installed don't need "complex" updating and installation/setup of additional modules with all its intricacies. If 6.x-1.x in essence is an OK module, websites wouldn't need to report the availability of security updates on every cron, either on the website itself or by e-mail. We've built several websites using this module. Some of those website are maintained by others nowadays...
Disabling the update module on all of our websites is an unwanted move, considering (seperate) maintainers who are informed just that way.
Thanks for all the hard work on this module, pillarsdotnet! It is really appreciated.
Comment #30
pillarsdotnet commentedThe 6.x-2.9 release removes the dependency on Echo and MailMIME.
Comment #31
Tino commentedAfter uploading the 6.x-2.9 release, the website is down again and reports Error 310 (net::ERR_TOO_MANY_REDIRECTS).
After removing the htmlmail folder, the website is back online but now shows the following warning about 25 times:
Please install the required Mail System module, then re-enable HTML Mail
Rolling back again...
Comment #32
esbon commentedSame here! rolled back to htmlmail 6.x-1.7 our site use smtp auth module and has system fully functional php-pear installation
thanks
Comment #33
pillarsdotnet commentedInteresting. I'll re-test the upgrade path. Works fine, btw, if you disable htmlmail, upgrade, then re-enable htmlmail. The redirects are to the admin/buildmodules page so you can do the re-enable bit.
Comment #34
pillarsdotnet commentedFixed in 6.x-2.11 -- at least it works for me in testing.
Comment #35
Tino commented6.x-2.12 sais it is still dependent on module Mail System. Is that correct?
And even after installing Mail System, all previous settings of HTML have disappeared! Template settings and header/footer images are gone...
Instead there are 3 completely new steps extensively described on the settings page which looks like a totally new approach on things and unexpectedly looks a little overwhelming imho. All of these things require a new setup and a unforseen work. This I have not seen mentioned in the notes on the module page of htmlmail on Drupal.org.
I still pledge keeping a seperate and safe 6.x-1.x branche without all these major changes and dependencies... It was such a simple and straighforward module and very much appreciated that way as far as I'm concerned.
Htmlmail wouldn't be the first Drupal module with seperate branches.
Thanks again.
Comment #36
pillarsdotnet commentedOkay, I'll let you in on the super-secret link at the bottom of the project page. It looks like this:
There. Now you have access to the old, unsupported versions. Problem solved.
Comment #37
pillarsdotnet commentedComment #38
pillarsdotnet commentedI will say it again.
If you or anyone else wants to support the 6.x-1.x version, contact Chris Herberte and ask for maintainer access.
Then you can mark it "supported" and start responding to support requests.
(waiting... waiting ... waiting...)
(I hear crickets.)
(very, very quiet crickets.)
So? You don't want to be the new maintainer of the 6.x-1.x branch? Me neither. I don't use that code and never have.
I submitted a bunch of patches to the 7.x branch and eventually created the 6.x-2.x (NOTE: That's a MAJOR VERSION NUMBER BUMP which traditionally means NEW FEATURES) so that I could have the same code running on 6.x and on 7.x.
Once I had functional code on both 6.x-2.x and 7.x-2.x, I went back to the project page and unchecked the "Supported" box next to the 6.x-1.x and 7.x-1.x versions. That is a public declaration that I don't want to maintain/fix/support/patch/upload/download/look at the old version any more. You don't like that? Sorry. Pay me a salary and I might reconsider.
What? You don't like the new version? Feel free to keep using the old one; I couldn't delete it from drupal.org even if I wanted to.
What? You don't like my attitude? Feel free to switch to Mime Mail which has five times as many users and is currently supported on 6.x.
According to Drupal policy, this project shouldn't even exist -- it should have merged with Mime Mail ages ago.
Comment #39
Tino commentedDear Bob,
This discussion is becoming a little awkward and I am not sure if you appreciate and understand our concerns on this security update. I am well aware of the possibility of accessing old, unsupported versions via the super-secret link. But having a perfectly working and much appreciated, easy to configure htmlmail 6.x-1.7 module on several websites, every time on (auto) cron, module update will still alert maintainers that there is a security update. Maintainers have been taught not to leave it at that. ;-)
This update will have unexpected consequences in functionality and on every website (some of us maintain many) a completely new setup is required. If I hadn't sent a test email, I wouldn't even have noticed that the old template does not work anymore. I have been working with Drupal for several years and have never updated a module having to deal with consequences like that, especially when theay are not mentioned in the notes of that release.
So, in my opinion, if there has ever been a module update that calls for a new/seperate branch - due to serious changes in functionality and the implications of that - this is it.
Once again thanks for your contributions to the community!
Edit: didn't read #38 before posting.
Comment #40
pillarsdotnet commentedSee Dave Reid's response to #1120214: Request to make upgrade a "Recommended Upgrade Vs Security Upgrade"
Comment #41
Anonymous (not verified) commentedOh don't worry, Mime Mail is on the agenda for my projects.
Update advanced from #40 should be sufficient in the meantime, thanks for the link.
And thanks for this module. I meant no harm with my message, I just was somewhat irked that a version with such a major overhaul and new features meant the older version (that apparently still works fine) was a security risk. I have never seen it done this way in any module.
Comment #42
Ela commentedI modified the html module info file in order not to get the warnings, so it's not called as in "available updates" at all... Will also have to consider mime mail, thought this module worked perfectly .. till now.
Comment #43
sterndata commentedBy template, I mean the settings I had set in the "current" version. I had a header and footer. It seems that there's no place for those settings and I have to create a xxx.php.tpl file. Correct?
Comment #44
pillarsdotnet commented@sterndata -- Yes, I was trying to trim down the number of redundant controls and didn't see the need for both.
Comment #45
jddeli commentedI cant work html mail with Mail MIME there is not a guide to put pear in my site.
I have apatch php php my admin.
I want to use this module but there is not a guide how i can but pear in my site and what to i have to enter in pear
Comment #46
jddeli commentedMake the effort to but same guides
Comment #47
pillarsdotnet commentedComment #48
sterndata commentedI've got it working on my production system now, with only one problem (that I've worked around). Our default theme is in sites/all/themes/ghb2. I put an edited version of htmlmail.tpl.php there, but it wasn't getting used. I copied that file into sites/all/modules/htmlmail and it is used. I can live with this; I just added it to my notes on things to watch for when updating modules.
Comment #49
pillarsdotnet commented@sterndata -- thanks for the feedback. Also see #1121894: Template files should go in the HTMLMail-specific theme directory..
Comment #50
pillarsdotnet commentedComment #51
pillarsdotnet commentedSee #1150140: Allow through-the-web editing of templates.
Comment #52
pillarsdotnet commentedAnyone who is still looking for a clean upgrade from HTML Mail 6.x-1.3 to HTML Mail 6.x-2.x should subscribe to #1150140: Allow through-the-web editing of templates.