Fatal error: Interface 'MailSystemInterface' not found in .../sites/all/modules/htmlmail/htmlmail.mail.inc on line 18

Comments

bailsbails’s picture

Likewise, rolled back to previous version!

Nosfe’s picture

Same here. rolled back too.

pillarsdotnet’s picture

Version: 6.x-2.3 » 6.x-2.4
Status: Active » Fixed

Fixed in 6.x-2.4 -- sorry. Been a lot of rapid changes these past couple of days while I was consolidating the 6.x and 7.x branches.

Tino’s picture

Thanks, but still having the same error message.
Now in line 19...

Rob_Feature’s picture

Same here

pillarsdotnet’s picture

Status: Fixed » Postponed (maintainer needs more info)

What version of the Mail MIME and Mail System modules are you using?

virtuali1151’s picture

same here... in the latest dev version:

PHP Fatal error: Interface 'MailSystemInterface' not found in /home/site/public_html/sites/all/modules/htmlmail/htmlmail.mail.inc on line 19

pillarsdotnet’s picture

Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new642 bytes

Try this patch, or grab the latest dev version (updating now.)

jimmyobomsawin’s picture

Status: Active » Postponed (maintainer needs more info)

Same error. Seems that the 2.x version adds dependencies that weren't there before. I deleted the htmlmail folder so I could access the site again, installed and enabled Mail System, Mail MIME, and Echo, then installed and enabled htmlmail. Everything is back to normal.

pillarsdotnet’s picture

Status: Postponed (maintainer needs more info) » Needs work

Okay, I need to add an update hook that prints an intelligent error message if someone updates from 6x.-1.x to 6.x-2.x and doesn't install prerequisites.

Tino’s picture

Not using Mail MIME or Mail System at all...

pillarsdotnet’s picture

Version: 6.x-2.4 » 6.x-2.5
Status: Needs work » Fixed

Fixed in 6.x-2.5. If you upgrade from 6.x-1.x to 6.x-2.x without first installing and enabling dependencies, HTML Mail will warn about the missing dependencies, disable itself, and redirect to the module page.

pillarsdotnet’s picture

Version: 6.x-2.5 » 6.x-2.6

Version bump. 6.x-2.5 had a syntax error, sigh.

Vc Developer’s picture

Same here! rolled back to htmlmail 6.x-1.7......

pillarsdotnet’s picture

Title: Website down after uploading 6.x-2.3 (Fatal error) » 6.x-2.3, 6.x-2.4, 6.x-2.5 versions won't cleanly upgrade from 6.x-1.x. Fixed in 6.x-2.6.
pillarsdotnet’s picture

Title: 6.x-2.3, 6.x-2.4, 6.x-2.5 versions won't cleanly upgrade from 6.x-1.x. Fixed in 6.x-2.6. » Upgrade from 6.x-1.x to 6.x-2.x broken prior to 6.x-2.6.
Ela’s picture

.. why all the new dependencies? 1.7 version was working fine?

pillarsdotnet’s picture

The dependencies in the 2.x branch provide features and flexibility lacking in the 1.x branch:

Echo (39 lines)
-- Lets you use any one of 859 themes to format your messages.
Emogrifier (261 lines)
-- Including emogrifier in the 1.x branch violated drupal policy. For the 2.x branch, I moved the Drupal wrapper code to a separate module and used the Libraries API to reference the emogrifier.php file. This is the currently-recommended way to handle such dependencies.
Mail System (281 lines)
-- This is a backport of the Drupal-7 mail system, which lets multiple email-sending modules co-exist within the same site. Want to use Mime Mail for some messages and HTML Mail for others? Support this patch.
Mail Mime (379 lines)
-- Auto-downloads, includes, and provides Drupal-friendly wrappers for the excellent PEAR Mail_mime package. This allows HTMLMail to gracefully coexist with other modules that may generate MIME attachments before invoking the drupal_mail() function. The fix is to parse the message body for MIME attachments before adding additional formatting. As an added bonus, any referenced image files are auto-included as inline attachments. so the recipient never has to answer a scary Do you want to enable remote content? question. This also resolves issues such as:
Additional features of the 2.x branch
-- You can specify a pre-theme and post-theme filter to make additional modifications to the message body. This lets you integrate HTML Mail with your choice of 241 filter modules.

All of the above helps distinguish HTML Mail from the competition.

pillarsdotnet’s picture

Version: 6.x-2.6 » 6.x-2.7

Another version bump.

jddeli’s picture

This is not working.

pillarsdotnet’s picture

jddell -- you'll have to be a bit more specific, if you want my help fixing things.

Anonymous’s picture

Why exactly was the 2.x branch marked as a security update from 1.x? When attempting to upgrade there is a very different setup and process for implementing HTML email than the 1.x branch. The module was rewritten it looks like and we're basically being "forced" to upgrade because it's flagged as a security update.

Is this an error or just really poor development choice?

Rob_Feature’s picture

#22: My question exactly. It seems that a security release was chosen simply to force people to upgrade to 2.x. If so, that's a really bad idea.

Tino’s picture

+1 #22. The module simply does exactly what I want it to do. If for security reasons it is not necessary to upgrade and to install additional modules I am not familiar with, I'd rather leave it as was. The less modules, the better I'd say. Less (maintanance) work as well... Maybe the 1.x-branch can stay "alive" without dependencies?

pillarsdotnet’s picture

I don't know where this "security release" idea is coming from.

It's just that I'm not willing to support the 6.x-1.x/7.x-1.x branches any longer, so I unchecked their "Supported" checkbox on the project's "Administer releases" page.

Ela’s picture

Maybe the 1.x-branch can stay "alive" without dependencies?

+1

sterndata’s picture

This is REALLY DISRUPTIVE update. It should have nicely converted my existing template, but that's gone. After reverting, I get dire warnings from Drupal about using unsupported modules.

pillarsdotnet’s picture

Title: Upgrade from 6.x-1.x to 6.x-2.x broken prior to 6.x-2.6. » Upgrade from 6.x-1.x to 6.x-2.x brokenness
Status: Fixed » Active

I'm sorry about the "dire warnings", but you can always disable the update module if they bother you that much.

The 6.x-1.x branch has been unsupported for quite some time, really. Neither Chris Herberte nor I want to support it. If you want to support it, ask for maintainer access.

I can always fork the 6.x-2.x/7.x-2.x branch off to a separate module.

On a separate note, I don't see how it's possible for a module upgrade to rewrite your template files. Can you point me to an example of another module that rewrites template files? i'd like to look at the code.

Tino’s picture

If 6.x-1.x is a safe module that doesn't need updating for security reasons, I would really appreciate a seperate branch for 2.x. Then all websites with 1.x installed don't need "complex" updating and installation/setup of additional modules with all its intricacies. If 6.x-1.x in essence is an OK module, websites wouldn't need to report the availability of security updates on every cron, either on the website itself or by e-mail. We've built several websites using this module. Some of those website are maintained by others nowadays...

Disabling the update module on all of our websites is an unwanted move, considering (seperate) maintainers who are informed just that way.

Thanks for all the hard work on this module, pillarsdotnet! It is really appreciated.

pillarsdotnet’s picture

Version: 6.x-2.7 » 6.x-2.9
Status: Active » Fixed

The 6.x-2.9 release removes the dependency on Echo and MailMIME.

Tino’s picture

After uploading the 6.x-2.9 release, the website is down again and reports Error 310 (net::ERR_TOO_MANY_REDIRECTS).
After removing the htmlmail folder, the website is back online but now shows the following warning about 25 times:
Please install the required Mail System module, then re-enable HTML Mail
Rolling back again...

esbon’s picture

Same here! rolled back to htmlmail 6.x-1.7 our site use smtp auth module and has system fully functional php-pear installation

thanks

pillarsdotnet’s picture

Interesting. I'll re-test the upgrade path. Works fine, btw, if you disable htmlmail, upgrade, then re-enable htmlmail. The redirects are to the admin/buildmodules page so you can do the re-enable bit.

pillarsdotnet’s picture

Version: 6.x-2.9 » 6.x-2.11

Fixed in 6.x-2.11 -- at least it works for me in testing.

Tino’s picture

6.x-2.12 sais it is still dependent on module Mail System. Is that correct?
And even after installing Mail System, all previous settings of HTML have disappeared! Template settings and header/footer images are gone...

Instead there are 3 completely new steps extensively described on the settings page which looks like a totally new approach on things and unexpectedly looks a little overwhelming imho. All of these things require a new setup and a unforseen work. This I have not seen mentioned in the notes on the module page of htmlmail on Drupal.org.

I still pledge keeping a seperate and safe 6.x-1.x branche without all these major changes and dependencies... It was such a simple and straighforward module and very much appreciated that way as far as I'm concerned.
Htmlmail wouldn't be the first Drupal module with seperate branches.

Thanks again.

pillarsdotnet’s picture

Okay, I'll let you in on the super-secret link at the bottom of the project page. It looks like this:

View all releases

There. Now you have access to the old, unsupported versions. Problem solved.

pillarsdotnet’s picture

Version: 6.x-2.11 » 6.x-2.x-dev
pillarsdotnet’s picture

Status: Fixed » Closed (won't fix)

I will say it again.

If you or anyone else wants to support the 6.x-1.x version, contact Chris Herberte and ask for maintainer access.

Then you can mark it "supported" and start responding to support requests.

(waiting... waiting ... waiting...)

(I hear crickets.)

(very, very quiet crickets.)

So? You don't want to be the new maintainer of the 6.x-1.x branch? Me neither. I don't use that code and never have.

I submitted a bunch of patches to the 7.x branch and eventually created the 6.x-2.x (NOTE: That's a MAJOR VERSION NUMBER BUMP which traditionally means NEW FEATURES) so that I could have the same code running on 6.x and on 7.x.

Once I had functional code on both 6.x-2.x and 7.x-2.x, I went back to the project page and unchecked the "Supported" box next to the 6.x-1.x and 7.x-1.x versions. That is a public declaration that I don't want to maintain/fix/support/patch/upload/download/look at the old version any more. You don't like that? Sorry. Pay me a salary and I might reconsider.

What? You don't like the new version? Feel free to keep using the old one; I couldn't delete it from drupal.org even if I wanted to.

What? You don't like my attitude? Feel free to switch to Mime Mail which has five times as many users and is currently supported on 6.x.

According to Drupal policy, this project shouldn't even exist -- it should have merged with Mime Mail ages ago.

Tino’s picture

Dear Bob,
This discussion is becoming a little awkward and I am not sure if you appreciate and understand our concerns on this security update. I am well aware of the possibility of accessing old, unsupported versions via the super-secret link. But having a perfectly working and much appreciated, easy to configure htmlmail 6.x-1.7 module on several websites, every time on (auto) cron, module update will still alert maintainers that there is a security update. Maintainers have been taught not to leave it at that. ;-)
This update will have unexpected consequences in functionality and on every website (some of us maintain many) a completely new setup is required. If I hadn't sent a test email, I wouldn't even have noticed that the old template does not work anymore. I have been working with Drupal for several years and have never updated a module having to deal with consequences like that, especially when theay are not mentioned in the notes of that release.
So, in my opinion, if there has ever been a module update that calls for a new/seperate branch - due to serious changes in functionality and the implications of that - this is it.
Once again thanks for your contributions to the community!

Edit: didn't read #38 before posting.

pillarsdotnet’s picture

Status: Closed (won't fix) » Fixed
Anonymous’s picture

Oh don't worry, Mime Mail is on the agenda for my projects.

Update advanced from #40 should be sufficient in the meantime, thanks for the link.

And thanks for this module. I meant no harm with my message, I just was somewhat irked that a version with such a major overhaul and new features meant the older version (that apparently still works fine) was a security risk. I have never seen it done this way in any module.

Ela’s picture

I modified the html module info file in order not to get the warnings, so it's not called as in "available updates" at all... Will also have to consider mime mail, thought this module worked perfectly .. till now.

sterndata’s picture

By template, I mean the settings I had set in the "current" version. I had a header and footer. It seems that there's no place for those settings and I have to create a xxx.php.tpl file. Correct?

pillarsdotnet’s picture

@sterndata -- Yes, I was trying to trim down the number of redundant controls and didn't see the need for both.

jddeli’s picture

I cant work html mail with Mail MIME there is not a guide to put pear in my site.
I have apatch php php my admin.
I want to use this module but there is not a guide how i can but pear in my site and what to i have to enter in pear

jddeli’s picture

Make the effort to but same guides

pillarsdotnet’s picture

Status: Fixed » Closed (won't fix)
sterndata’s picture

I've got it working on my production system now, with only one problem (that I've worked around). Our default theme is in sites/all/themes/ghb2. I put an edited version of htmlmail.tpl.php there, but it wasn't getting used. I copied that file into sites/all/modules/htmlmail and it is used. I can live with this; I just added it to my notes on things to watch for when updating modules.

pillarsdotnet’s picture

pillarsdotnet’s picture

Status: Closed (won't fix) » Closed (fixed)
pillarsdotnet’s picture

Status: Closed (fixed) » Closed (duplicate)

Anyone who is still looking for a clean upgrade from HTML Mail 6.x-1.3 to HTML Mail 6.x-2.x should subscribe to #1150140: Allow through-the-web editing of templates.