Each services (Dnsmasq, Bind and Bind slave) have a specific classe inherited from provisionService_dns because they need differents configuration files:

  • Dnsmasq needs to create server, zone and host configuration files
  • Bind needs to create server and zone config files
  • Bind slave needs to create server config files

However, functions create_host, create_zone aren't overloaded to do exactly the right work. Each services use the same general function who deals with warnings to do the work.

CommentFileSizeAuthor
#2 hosting_dns_service_specific_create_config_function-1118286-2.patch3.32 KBthomas bosviel

Comments

anarcat’s picture

anarcat commented
Version: 6.x-1.0-rc4 » 6.x-1.0-rc5

This was a quote from #1083710: [DNS] PHP 5.3 warning fixes and it's incomplete, to complete it, it ends with:

I think create_zone() function in provisionService_dns_bind_slave() class was originaly wrote to pass the master server IP to config class before generating the config file. Now, the master server IP is recovered from the context in the config class ... I have reused this code to solve this issue.

Okay, that was what I was worried about - loosing the master IP in the change. It seems you have thought of all this, and this should be merged in. Can you reroll a patch here?

thomas bosviel’s picture

thomas bosviel commented
Status: Active » Needs review
Issue tags: +dns
StatusFileSize
new hosting_dns_service_specific_create_config_function-1118286-2.patch3.32 KB
anarcat’s picture

anarcat commented

I have given you commit access to the provision module, after discussions with the rest of the team, if you still want it of course. :)

You can therefore commit that patch yourself. Welcome and congratulations!

Please keep your commits limited to the DNS subsystem right now, until we get a good grasp of where you can go. If you see some quick fixes elsewhere, feel free to push commits, but at least open an issue documenting your change here.

Also, regarding that specific patch - it blends whitespace and topical changes, please keep whitespace changes separate.

Thanks!

thomas bosviel’s picture

thomas bosviel commented
Status: Needs review » Fixed

Fix committed!

Status: Fixed » Closed (fixed)
Issue tags: -dns

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +dns

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 329c5bd on 6.x-1.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by Thomas Bosviel: 
    Issue #1118286: specific config functions for each DNS service.
  • Commit baa8026 on debian, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by Thomas Bosviel, committed by anarcat:
    Issue #1118286: specific config functions for each DNS service.