Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Each services (Dnsmasq, Bind and Bind slave) have a specific classe inherited from provisionService_dns because they need differents configuration files:
- Dnsmasq needs to create server, zone and host configuration files
- Bind needs to create server and zone config files
- Bind slave needs to create server config files
However, functions create_host, create_zone aren't overloaded to do exactly the right work. Each services use the same general function who deals with warnings to do the work.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | hosting_dns_service_specific_create_config_function-1118286-2.patch | 3.32 KB | thomas bosviel |
Comments
Comment #1
anarcat commentedThis was a quote from #1083710: [DNS] PHP 5.3 warning fixes and it's incomplete, to complete it, it ends with:
Okay, that was what I was worried about - loosing the master IP in the change. It seems you have thought of all this, and this should be merged in. Can you reroll a patch here?
Comment #2
thomas bosviel commentedComment #3
anarcat commentedI have given you commit access to the provision module, after discussions with the rest of the team, if you still want it of course. :)
You can therefore commit that patch yourself. Welcome and congratulations!
Please keep your commits limited to the DNS subsystem right now, until we get a good grasp of where you can go. If you see some quick fixes elsewhere, feel free to push commits, but at least open an issue documenting your change here.
Also, regarding that specific patch - it blends whitespace and topical changes, please keep whitespace changes separate.
Thanks!
Comment #4
thomas bosviel commentedFix committed!