See the attached image. There are some black pixels around the rounded corner. Tried to change the order of actions but same result.

Can this be the result of GD version I run? This is reported by admin/reports/status:

GD Image Filtering	Low Quality / Poor Performance
The installed version of PHP GD does not support image filtering(desaturate, blur, negate, etc). It was probably compiled using the official GD libraries from http://www.libgd.org instead of the GD library bundled with PHP. You should recompile PHP --with-gd using the bundled GD library. See PHP Manual for more information. A slower implementation of imagefilter() written in PHP will be used in the interim.
CommentFileSizeAuthor
#4 imagecache_canvasactions-1118490.patch2.46 KBclaudiu.cristea
#1 rounded.jpg13.9 KBclaudiu.cristea
icon.jpg51.1 KBclaudiu.cristea

Comments

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
StatusFileSize
new rounded.jpg13.9 KB

Running the same actions on PHP 5.3 with GD 2 - no warnings in admin/reports/status

Same behavior with corners. See attached image.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Title: Rounded corners add some dirt in corners » Rounded corners are dirty
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

It seems that this is affecting corners where the cut is on transparent area

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
StatusFileSize
new imagecache_canvasactions-1118490.patch2.46 KB

The bug consist in use of variable $rgba instead of $color. I added also a little performance improvement by checking if $color['alpha'] is not 127 and process pixels opacity only in that case. Otherwise pass 127.

InTheLyonsDen’s picture

InTheLyonsDen commented

I'm having the same issue with D7. Has anyone (or could anyone) adapt this patch for D7? Thanks!

dman’s picture

dman commented

I can replicate in D7.
I can confirm that the patch (applied by hand to D7) does fix it.
So cool. Thanks.
I can see why rounded corners on transparent input would not have been a test case :-)

#4 by claudiu.cristea, is now applied to D7-dev
http://drupal.org/commitlog/commit/6286/6158e6caadcaba8edbf5103483638900...
Raw patch for D7 here
http://drupalcode.org/project/imagecache_actions.git/blobdiff_plain/7544...

dman’s picture

dman commented
Status: Needs review » Closed (fixed)

Fix is only in -dev (not a stable yet) but I'll flag it as nominally done, there's a bunch of things in the queue I've got to chew through.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

Please commit also to D6. It's from April 2011! That patch is on production from then.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Closed (fixed) » Reviewed & tested by the community
InTheLyonsDen’s picture

InTheLyonsDen commented

The new dev version works great. I did have to resave the presets that were utilizing the rounded corners which is logical. Thank you!

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

I'm glad that works but, as finder of bug and author of patch, I would be very happy to have it pushed also in 6.x-1.x branch :-) It was applied and is successfully working on big production site since April 2011.

Thanks!

dman’s picture

dman commented

Sure. I can push that in to D6 no problem.
It was just about what versions of code I had open this week. TODO.

rsvelko’s picture

rsvelko commented

found this one after 2 hours googling... should've searched the issue queue as usual...
keywords:
php rounded corners black
drupal imagecache rounded corners black

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Closed (won't fix)

D6 EOL. This module's D6 issues already haven't received any attention for over a year. Closing them all unconditionally now.