Download & Extend

includes do not support absolute paths

Project:Drush Make
Version:6.x-2.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

It is useful for us to reference system-wide include files. For example, we would like to override the aegir makefile in our own distribution, this way:

includes[aegir] = "/var/aegir/.drush/provision/aegir.make"

or, with the debian package:

includes[aegir] = "/usr/share/drush/commands/provision/aegir.make"

Neither works. The documentation says the path is "relative" but doesn't explicitely say that absolute paths are forbidden. I tried an absolute path, thinking myself very smart, but that didn't work either:

includes[aegir] = "../../../../usr/share/drush/commands/provision/aegir.make"

... even though that actually works on the commandline.

This needs to be clarified in the documentation or clearly allowed. I would like to see this implemented.

Comments

#1

Status:active» needs review

First pass. Simple enough, works here.

AttachmentSize
1118616_absolutes.patch 905 bytes

#2

Status:needs review» reviewed & tested by the community

Subscribe- I need this for the same reason. The patch in #1 seems to work fine. Thanks!

#3

Status:reviewed & tested by the community» fixed

Awesome! Just what I needed!

I committed the patch to 2.x (a2b2a01) and 3.x (61f23ea), thanks for the testing!

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.