Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The attached patch provides basic upgrading and code cleaning for 4.5 compliance plus some minor changes/enhancements, including:
- updated taxonomy term and node paths to 4.5 versions
- doxygen-style commenting
- node access included in node SELECT queries
- removes theme_trip_search_form (inappropriate use of theme_, since it's generating rather than formatting content)
Unless I've missed something obvious the module should be ready for initial 4.5 release with these changes--though lots more enhancements could be added.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | trip_search.update-to-45_0.patch | 17.56 KB | nedjo |
| trip_search.update-to-45.patch | 17.29 KB | nedjo |
Comments
Comment #1
moshe weitzman commentedThanks much for this patch. You may apply it yourself, after fixing the following
- DONT USE THE INIT HOOK for "run this once" code. That causes this module to be loaded even for chached page views. This nullifies the whole bootstrap process. Instead, put this code in hook_menu(), within a conditional: if (!$may_cache).
- should the hook_menu stuff not be within a if ($may_cache)
- just a not, but some of you code cleanup added punctuation marks instead of removed see query in comment_trip_search). no big deal though.
- replace theme_item_list() calls with theme('item_list', )
Comment #2
nedjoHere is the revised patch, which I have applied. The module should now be ready for 4.5 branch tagging. I couldn't however test it fully since in my test installation, which I've just updated to 4.5 RC, I can't find a way to set the roles and permissions. (I'll have to regenerate the database and see if that's the source of the error--or if I'm just overlooking the obvious.)
Comment #3
(not verified) commented