Closed (fixed)
Project:
Office Hours
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Apr 2011 at 12:09 UTC
Updated:
27 Mar 2017 at 01:44 UTC
Jump to comment: Most recent
Comments
Comment #1
johnvSome more thoughts:
- the field might be text field, or a term. A term field might be better: admin can allow/prohibit adding new texts.
- what about translatability of the text?
Comment #2
Ozeuss commentedUser-entered text should not be translatable- there's no way to know in what language the text was entered.
Comment #3
johnvOne can assume that the text is in the same language as the Entity-language, if languages are enabled.
If locale-module is not enabled, then translation is not an issue.
How would a text per line be implemented?
Comment #4
johnvAnother use case in #555054: Allow for custom "day" and "hour" name schemes, IE "Mon-Fri", "Appointment Only", which needs the following options for an Opening Day:
Closed
Appointment Only
etc..
Comment #5
johnvMarked #665082: Assigning a "Room Number" when an hour is specified as a duplicate:
Comment #6
johnvMarked #349746: Nonstop checkbox as a duplicate:
Comment #7
Anonymous (not verified) commented+1 subscribing to this.
suggestion:
in the CCK field settings, maybe having a box where one could type the list of options that they would like to see in their selection boxes would be the best idea. Much like creating a list style text field.
i was thinking perhaps an admin page where one could assign new selections to the Office Hours fields, but if I have two Office Hours fields per node, I would then see selections in both that I may not want to appear within both field options.
so adding extra options to the actual field settings page itself would be ideal.
Comment #8
tommer commentedI also need the possibility to add nonstop. My temporary solution is this modification in office_hours.theme.inc (marked by ++ in code below) somewhere around line 190 (in 6.x-1.x-dev):
It works when the opening hours are set from: 00:00, until: 00:00
Comment #9
johnvMarked as duplicate: #1905128: Hours description
Comment #10
johnvSee both linked issues for D7 and D8. It adds a 'comment' column to each time slot.
Perhaps, we can build upon that.
For D8 this is fixed:
OP: When only open on the last sunday of the month, the formatter shows 'sunday: 11:00-17:00, every last sunday of the month'. --> #2860038: Add a comment field to each time slot (D8)
OP: When closed on mondays, the formatter shows all days, with 'monday: closed' --> #2860041: Cannot add comment when day is closed.
#2: User-entered text should not be translatable- there's no way to know in what language the text was entered. --> #2860044: Make Comment line translatable via Field setting
#7: We stick to a common textfield.
#8: non-stop is possible now.