On a multilingual website with i18n and menu translation, the breadcrumb title is not translated if I use breadcrumb reaction.

I've written a little patch that should solve this.

CommentFileSizeAuthor
#2 translate_the_title_on_multilingue_website-1119596-2.patch621 bytesfxarte
#1 context-1119596-1.patch1.03 KBplach
context_reaction_breadcrumb_i18n.patch691 bytesyraber

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new context-1119596-1.patch1.03 KB

The patch from the OP works as advertised, I made some small improvement.

fxarte’s picture

fxarte commented
StatusFileSize
new translate_the_title_on_multilingue_website-1119596-2.patch621 bytes

I think another solution is to allow any module to tap into the breadcrumb reaction query. We can accomplish this by adding a tag to it, then implementing hook_query_alter.
Here is a patch that adds the tag.

function mymodule_query_alter(QueryAlterableInterface $query) {
  if ($query->hasTag('context_reaction_breadcrumb')) {
    $query->condition('language', array(LANGUAGE_NONE , $GLOBALS['language']->language), 'IN');
  }
}
iamEAP’s picture

iamEAP commented
Version: 7.x-3.0-beta1 » 7.x-3.x-dev
Category: task » bug

Cleaning up issue details.

iamEAP’s picture

iamEAP commented
Status: Needs review » Reviewed & tested by the community

Not sure that @fxarte's approach in #2 is appropriate; this should Just Work™ for admin without developer involvement.

With that being said the approach taken in #1 (and also the original patch) seems good. I applied and tested #1 and it worked as expected.

Marking the patch in #1 as RTBC.

iamEAP’s picture

iamEAP commented

And... Yup. This is still working great.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed #1 in a9116ab.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.