This module (v 6.13) is miscalculating the order subtotal line item. The total amount deducted from the gift certificate seems to be accurate, but the subtotal line item figures are off. The line item "Subtotal excluding taxes" shows the tax amount as a deduction (negative) and then the tax line item shows the tax amount (positive). see attached screen shot.

CommentFileSizeAuthor
#5 uc_gift_certificate-fix_subtotal_before_tax_amount-1119762-5.patch1.31 KBdpintats
Subtoatl-line-item.jpg14.75 KBkenheim

Comments

kenheim’s picture

kenheim commented

Bump! I've confirmed that this only occurs when the gift certificate is being applied.

kenheim’s picture

kenheim commented

Please help. Going live soon and need this issue resolved.

kenheim’s picture

kenheim commented
Priority: Major » Normal

Maybe this is related to http://drupal.org/node/393608 ??

kenheim’s picture

kenheim commented

Bump

dpintats’s picture

dpintats commented
Version: 6.x-1.3 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new uc_gift_certificate-fix_subtotal_before_tax_amount-1119762-5.patch1.31 KB

I was having the same issue you mentioned in your original post and was not able to find a patch that addressed it. I have created a patch that adjusts the subtotal before tax amount when reviewing the order, as well as the admin order overview page.

I was additionally having issues validating the amount on submitting the cart for review, so I also included the tax amount(s) to the order total on save so that the gift certificate will correctly deduct all amounts.

Btw, this is my first patch....please be gentle ;)

1kenthomas’s picture

1kenthomas commented

Subscribing. Affects 2.0-dev as well, I'll see if the above patch can be used.

1kenthomas’s picture

1kenthomas commented

I tried to use the patch code for -2.x-dev but failed to find a way, perhaps because I found two other issues which took all day to fix.

@dpintats: would be much appreciated if you could look at -2.x-dev and spin a solution. Glad to help as well, if you can clarify what's going on... though, alas, I get how things work and your solution works in -1.x, just not -2.x.

1kenthomas’s picture

1kenthomas commented

I've hacked the submitted order display, but the checkout page calculations are not done by GC-- setting shipping / tax etc ignores GC. Ideas?

Looks like maintainer plans to fix this via .js, not yet implemented. Thanks.

1kenthomas’s picture

1kenthomas commented

@dpintats: .js needs updating. More later...

1kenthomas’s picture

1kenthomas commented
Status: Needs review » Closed (duplicate)

I'm going to close this as duplicate of open 2.x-dev issues/tickets. Please search there. Feel free to reopen if you feel necessary.