After installing the 7.x-1.7 version of this module I noticed that in ff4 and ie9 (though I don't think it is a browser issue) the reset button doesn't seem to do anything. After looking into the javascript of the module on line 98 it says element_to_resize.css('font-size', null);. I don't think null is valid css so instead I changed it to element_to_resize.css('font-size', ''); using a blank string instead and that seems to have fixed the issue. I will roll a patch when I get a chance and submit but I figured I would start the issue for now.

CommentFileSizeAuthor
#7 text_resize_reset-1119994-6.patch0 bytesdesmondmorris
#6 text_resize_reset-1119994-6.patch557 bytesdesmondmorris
#1 1119994-reset-bug-fix-0.patch534 bytesblischalk

Comments

blischalk’s picture

blischalk commented
StatusFileSize
new 1119994-reset-bug-fix-0.patch534 bytes

Uploading patch file for this issue.

blischalk’s picture

blischalk commented
Status: Active » Needs review

Changing status to needs review.

attheshow’s picture

attheshow commented
Status: Needs review » Closed (cannot reproduce)

"null" isn't meant to be CSS. It's a Javascript value.

I haven't been able to duplicate this in Firefox 4. Appears to still work fine as-is.

rovinrick’s picture

rovinrick commented
Status: Closed (cannot reproduce) » Patch (to be ported)

I experienced the same issue and the batch worked for me.

attheshow’s picture

attheshow commented
Status: Patch (to be ported) » Closed (cannot reproduce)
desmondmorris’s picture

desmondmorris commented
Status: Closed (cannot reproduce) » Active
StatusFileSize
new text_resize_reset-1119994-6.patch557 bytes

This did not work for me either. Tested in Chrome and Firefox. I saw that the patch had not been pushed. That patch does not account for the line-height reset though. I have attached a new patch.

desmondmorris’s picture

desmondmorris commented
Status: Active » Needs review
StatusFileSize
new text_resize_reset-1119994-6.patch0 bytes

I forgot to change the status in my last comment.

bluemaro’s picture

bluemaro commented

I can also confirm that reset button doesn't work and patch solve the problem (tested on Firefox 7 and chrome 15).
Look into documentation of jQuery how to remove style attributes using .css():
http://api.jquery.com/css/

Setting the value of a style property to an empty string — e.g. $('#mydiv').css('color', '') — removes that property from an element if it has already been directly applied, whether in the HTML style attribute, through jQuery's .css() method, or through direct DOM manipulation of the style property. It does not, however, remove a style that has been applied with a CSS rule in a stylesheet or

element.
jvandooren’s picture

jvandooren commented
Status: Needs review » Reviewed & tested by the community

Patch from #6 worked for me too (Text Resize 1.7, Chrome 15 & FF8)

Changing status...

Anonymous’s picture

Anonymous (not verified) commented

Patch from #6 worked for me too in FF

Marvine’s picture

Marvine commented

Same

Patch from #6 worked for me too in all browsers.

Thanks

jlea9378’s picture

jlea9378 commented

Solved the problem for me too. Can we get this patch committed?

h3rj4n’s picture

h3rj4n commented

Solved the problem for me too.

Also testen the functionality of the dev download. Seems to have the same bug. Haven't tested the patch on that version.

Can't this be included in the module?

jorisx’s picture

jorisx commented

Confirmed patch #6 works in all tested browsers,
please include in next module update.

attheshow’s picture

attheshow commented
Status: Reviewed & tested by the community » Fixed

Looks like null stopped working in jQuery 1.4.3. Updating to use an empty string instead of null. (Patch #6).
Committed to dev version. Thanks @desmondmorris!

desmondmorris’s picture

desmondmorris commented

No problem. Glad to help!

Status: Fixed » Closed (fixed)
Issue tags: -Text Resize, -Reset Button

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Text Resize, +Reset Button

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.