_views_find_module_templates not picking up custom view templates from features profiles (buildkit method) [#1121238]

hiya,

We are using the buildkit method with features for our deployment model.

In {site}/profiles/{project}/modules/features/{feature}/{feature}.features.inc, we specify the location of the custom template I want to use for a view within the feature as follows (whereas the feature is named 'rwce_events':

/**
 * Implementation of hook_views_api().
 */
function rwce_events_views_api() {
  return array(
    'api' => '3.0-alpha1',
    'path' => drupal_get_path('module', 'rwce_events') . '/views',
    'template path' => drupal_get_path('module', 'rwce_events') . '/views/templates',
  );
}

(I believe that's the way it's supposed to be done. If anyone has any advice otherwise, plz shoot.)

BUT, _views_find_module_templates in views.module doesn't find the path correctly in such cases.

I've attached a patch that addresses this. It could definitely use some review (I don't understand the inner workings of the views cache -- but the patch works).

We're on views alpha1, but from looking at the code, this is still an issue in dev3, so hoping a maintainer sees this.

Peace out to the views team,

Shiraz
(Affinity Bridge, Vancouver)

Comment	File	Size	Author
#3	views-_views_find_module_templates-features_path-1121238-2.patch	946 bytes	shiraz dindar
#1	views-_views_find_module_templates-features_path-1121238.patch	952 bytes	shiraz dindar
	views-_views_find_module_templates-features_path.patch	1.2 KB	shiraz dindar

Comments

Comment #1

shiraz dindar

Sooke, BC

commented 8 April 2011 at 17:34

Issue tags:

+views templates features buildkit

Status	File	Size
new	views-_views_find_module_templates-features_path-1121238.patch	952 bytes

Sorry, that first patch was in error. Here's the working version:

Comment #2

dawehner

German

commented 8 April 2011 at 17:55

Status:

Active

» Needs work

Can you please try to use drupal codestyle?


+          if (substr($path,0,8)=="profiles") {
+            $templatepath=$path;
+          }
+          else {
+            $templatepath=dirname($files[$match]->filename);
+          }

Additional it would be probably helpfull to explain it in a comment.

PS: you should really not use alpha1 anymore, it's really really old