After upgrading to 2.12 I stopped getting bodies in emails. I just upgraded to 2.15 (about the 6th update in the last week) and still no bodies but now I get

warning: implode(): Invalid arguments passed in /sites/all/modules/mailsystem/mailsystem.module on line 308.

I hadn't changed mailsystem.

Comments

jzornig’s picture

jzornig commented

I've gone back to 1.17 as the whole 2.x experience has been a nightmare.

pillarsdotnet’s picture

pillarsdotnet commented
Title: No longer getting any body in emails » Error in backport of D7 DefaultMailSystem
Project: HTML Mail » Mail System
Version: 6.x-2.15 » 6.x-1.10
Assigned: Unassigned » pillarsdotnet
Status: Active » Fixed

Redirecting -- this is a bug in Mail System, not in HTMLMail.

Line 308 of mailsystem.module is in the middle of a cut-and-paste backport of the Drupal-7 DefaultMailSystem::format() method.

In other words, you weren't even using HTMLMail at that point; you were using the DefaultMailSystem I backported from D7. You missed part of the instructions posted in the HTMLMail project page, Release Notes, and README.html:

Configuration

Visit the Mail System settings page at admin/settings/mailsystem to select which parts of Drupal will use HTML Mail instead of the default mail system.

Visit the HTML Mail settings page at admin/settings/htmlmail to select a theme and post-filter for your messages.

Admittedly, I haven't extensively tested the backport. It's just there so that I can have the same code in D6 and D7 versions of HTMLMail.

(looking...)

Hmm.. Actually it's due to a change between the d6 drupal_mail() and the d7 drupal_mail().

Fixed in MailSystem 2.11 release.

PS -- I'm sorry that you're unhappy with my pace of development, although it's unclear to me whether you'd rather I were quicker or slower.

jzornig’s picture

jzornig commented

Sorry to have sounded so negative. Must have caught me at a bad time. I've never come across a situation with another module where the release version is updating with such rapidity. I would have expected this to be happening on a dev version. Yet the only version (1.17) I find stable at present causes a site warning that it is no longer supported. It might be good to have a warning on the home page. I'll revisit the 2.x versions at some future point to check out the new functionality. That you are developing these modules is a great thing and much appreciated.

pillarsdotnet’s picture

pillarsdotnet commented

Well, at this point all the reported bugs are fixed, and I'm down to feature requests and documentation.

So you can expect the release number explosion to slow down somewhat from now on.

I'll still release a new version every time I make a change that I think is

  1. Safe,
  2. Generally useful.

For instance,

will mean an extra version bump each, maybe more if somebody finds and reports bugs.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.