Fatal error: Call to undefined function popup_element() in ...\popup\modules\popup_block\popup_block.module on line 87

Yip get the same WSOD. I applied it to a block and it just dies.

subscribing

subscribing

Me too... subscribing

OK, here is the deal. The popup_block_preprocess_block() is being fired before the popup.api.inc is loaded.

To fix:

At: popup/modules/popup_block/popup_block.module:87

Add:

 if(!function_exists('popup_element'))
	    module_load_include('inc', 'popup', 'includes/popup.api'); 

Right before popup_element() is called.

This will make sure this doesn't happen again.

Joe - thanks for the fix just started to use this module and after receiving the error found and installed this patch. All seem to be going well.

thanks for helping

can you refer me some other cool modules for creating better website

This works as stated. It can be committed.

Changing title back, as "thanks bhaji" isn't too helpful in finding issues...

Also, a better fix would be to include the line

  module_load_include('inc', 'popup', 'includes/popup.api');

at the beginning of the function, as we know we'll need it anyway.

Shawn

Great help, it worked. thanx..

Worked nicely. ... i wonder why it's not committed to stable release yet. thanks for help

Thanks all, this'll be in the next release.

I agree with others, this should be committed to the current release. I think it's important enough to constitute a 3.23 release. Thanks for the module.

Also this breaks the hole site, should be critical, just saying

I tried the fix in Comment #5 but then get this response:

Parse error: syntax error, unexpected '<' in /sites/all/modules/popup/modules/popup_block/popup_block.module on line 87

Please advise

Hi Eric,
Seems like you have included PHP opening tag, right? It's not needed and gives PHP error. Add just one line:

module_load_include('inc', 'popup', 'includes/popup.api');

at the beginning of function, so it will look like:

function popup_block_preprocess_block(&$variables){
  module_load_include('inc', 'popup', 'includes/popup.api');

  $settings = _popup_block_settings();
  $block = $variables['block'];
  $block_settings = $settings[$block->module.':'.$block->delta];

  if ($block_settings && $block_settings['active']){

    $attributes = array();

    $attributes['block'] = 1;
    $attributes['format'] = $block_settings['format'];
    $attributes['module'] = $block->module;
    $attributes['delta'] = $block->delta;

    $variables['block']->content = popup_element(
      $block->subject,
      $block->content,
      $attributes
    );
    $variables['block']->subject = '';
    
  }

}

Like a charm, thanks Michlis!

ATTN ALL w/ this issue: use solution #16

To be fixed, this issue first needs a patch and then the patch must be reviewed and committed. Until then, the problem persists on the downloadable version and the solution in this issue is just a workaround.

Thanks all, fix in new release