Invoice Email not sent correctly.

Marked #113293 duplicate.

From the post:

All the token values for ec_mail were coming through as [xxxxxx] in the emails with the default email templates. I tried changing them to [[xxxxx]] and the values were then all included correctly. Somewhere there is an extra [], not sure where though, either the default templates are wrong or some coding, or possibly some set-up by me.

I've changed $values['[txn-bill-plus-ship]'] to $values['txn-bill-plus-ship'] on all of the tokens, and it seems to fix it.

this is a bug with the store module

This does not fully work, some parts of some of the emails get sent correctly but not all.
With the default emails:

Cancel transaction works
Ask customer works
Shipping notify doesnt
Invoice Doesnt

The site variables always seem to work (such as site-name and email).

yep, after more testing this doesn't seem to work as I though it did.

I've found two transaction notification problems, for initial invoices and errors. I'm not up to creating a patch, but here's the relevant code with the errors commented out and followed by what works:

function store_send_invoice_email($txnid, $preview = null) {
  $t = store_transaction_load($txnid);

  if ($t->mail && valid_email_address($t->mail)) {
    $to = $t->mail;
  } elseif ($t->uid != 0) {
    $to = db_result(db_query("SELECT mail FROM {users} WHERE uid = '%d'", $t->uid));
  }

  $mid = variable_get(MAILVAR_CUSTOMER_INVOICE, 0);
  if ($preview) {
/*  return ec_mail_preview($mid, $to, ECMAIL_TYPE_CUSTOMER_INVOICE, $t);  */
    return ec_mail_preview($mid, $to, $t);
  }
  elseif ($to && valid_email_address($to)) {
/*    return ec_mail_send_mid($mid, $to, ECMAIL_TYPE_CUSTOMER_INVOICE, $t); */
    return ec_mail_send_mid($mid, $to, $t);
  }
  else {
    return false;
  }
}

function store_send_error_email($txnid, $preview = null) {
  $t = store_transaction_load($txnid);

  if ($t->mail && valid_email_address($t->mail)) {
    $to = $t->mail;
  } elseif ($t->uid != 0) {
    $to = db_result(db_query('SELECT mail FROM {users} WHERE uid = %d', $t->uid));
  }

  $mid = variable_get(MAILVAR_PROCESSING_ERROR, 0);

  if ($preview) {
/*     return ec_mail_preview($mid, $to, ECMAIL_TYPE_PROCESSING_ERROR, $t);  */
    return ec_mail_preview($mid, $to, $t);
  }
  elseif ($to && valid_email_address($to)) {
/*    return ec_mail_send_mid($mid, $to, ECMAIL_TYPE_PROCESSING_ERROR, $t);  */
    return ec_mail_send_mid($mid, $to, $t);
  }
  else {
    return false;
  }
}

This patch fixes the invoice, error and shipping email sending so they have the correct sender and content.

I just realized the version for this thread is HEAD, but the patch I submitted is for 4.7 v3b2.

This patch works great. Thanks

When has this been fixed? it is still apparent in 4.7.3