Download & Extend
Advanced CSS/JS Aggregation » Issues

CSSTidy - Corrupted CSS background image properties when "Preserve CSS" is disabled

Posted by droopy on April 10, 2011 at 7:34pm
Project:Advanced CSS/JS Aggregation
Version:6.x-1.0-rc2
Component:CSS Compression
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

I have installed the module with the default options and everything appears to be working correctly except collapsible form groups, where I get the corrupted text as in the attached image. Click on the link and the text appears correctly. Any suggestions?

AttachmentSize
advagg.jpeg19.86 KB
Login or register to post comments

Comments

#1

Posted by mikeytown2 on April 10, 2011 at 10:48pm

are you using the css_emimage module? Have you tried the patched version of it?
#1078060: CSS Embedded Images - Add in support for advagg's hooks

#2

Posted by mikeytown2 on April 10, 2011 at 10:51pm
Title:Corrupted text» Corrupted CSS background image properties

#3

Posted by droopy on April 11, 2011 at 5:04am

No, I'm not using css_emimage. It seems partly theme related. I use a modified version of the analytic theme. I get the same problem with bluemarine, but garland appears to work OK: collapsed form headings appear as normal.

#4

Posted by mikeytown2 on April 11, 2011 at 5:13am

I'm assuming the bundler is on?

#5

Posted by droopy on April 11, 2011 at 11:47am

Yes, it's on. I've flipped most of the settings and it doesn't seem to make any difference. Site works perfectly apart from that.

#6

Posted by mikeytown2 on April 11, 2011 at 5:18pm

on the page where it's messing up add on ?advagg-debug=1 in the url, copy the watchdog debug message and attach it as a txt file. Hopefully that will let me know where it messed up.

#7

Posted by droopy on April 12, 2011 at 5:41am

This is the debug output from a "create story" page, which had numerous corrupted collapsed form-group headers. Thanks for your help, by the way.

AttachmentSize
debug.txt 108.19 KB

#8

Posted by mikeytown2 on April 12, 2011 at 8:18am

What does firebug say... what file overwrote the no-repeat; property of background for the fieldset.collapsible legend a selector? Garland uses its own background image where bluemarine uses the system defaults. My guess is analytic uses the defaults.

CSS Compression turned on? Is "Preserve CSS" disabled?

Looking at the debug output I don't see any missing files in the CSS aggregates.

    [css_merged] => Array
        (
            [all] => Array
                (
                    [module] => Array
                        (
                            [modules/book/book.css] => 1
                            [modules/node/node.css] => 1
                            [modules/system/defaults.css] => 1
                            [modules/system/system.css] => 1
                            [modules/system/system-menus.css] => 1
                            [modules/user/user.css] => 1
                            [sites/default/modules/bible_field/bible_field.css] => 1
                            [sites/default/modules/cck/theme/content-module.css] => 1
                            [sites/default/modules/filefield/filefield.css] => 1
                            [sites/default/modules/footnotes/footnotes.css] => 1
                            [sites/default/modules/glossary/glossary.css] => 1
                            [sites/default/modules/mollom/mollom.css] => 1
                            [sites/default/modules/simplenews/simplenews.css] => 1
                            [sites/default/modules/typogrify/typogrify.css] => 1
                            [sites/default/modules/wysiwyg_imageupload/plugins/imgupload/imgupload.css] => 1
                            [sites/default/modules/cck/modules/fieldgroup/fieldgroup.css] => 1
                            [sites/default/modules/views/css/views.css] => 1
                            [sites/default/modules/admin_menu/admin_menu.css] =>
                            [sites/default/modules/admin_menu/admin_menu.uid1.css] =>
                            [sites/default/modules/wysiwyg/editors/css/tinymce-3.css] => 1
                            [sites/default/modules/jquery_ui_dialog/css/jquery_ui_dialog-dialog/jquery_ui_dialog.css] => 1
                            [sites/default/modules/jquery_ui_dialog/css/jquery_ui_dialog.main.css] => 1
                            [sites/default/modules/imagefield/imagefield.css] => 1
                            [sites/default/modules/link/link.css] => 1
                            [sites/default/modules/finder/finder.css] => 1
                        )

                    [theme] => Array
                        (
                            [sites/default/themes/analytic_modified/style.css] => 1
                            [sites/default/themes/analytic_modified/local.css] => 1
                        )

                )

        )

Files included in html output

/sites/default/modules/admin_menu/admin_menu.css
/sites/default/modules/admin_menu/admin_menu.uid1.css
/sites/default/files/advagg_css/css_c7ab3c8f60caffae72a6add426147964_0.css
/sites/default/files/advagg_css/css_f2884fcc99e132712e76bb6de584208a_0.css
/sites/default/files/advagg_css/css_1ff36e097b0752f8304d03e0980d88b3_0.css
/sites/default/files/advagg_css/css_4329a942c3351bedea2572f3820acd9e_0.css

Contents of the 4 CSS files

            [file_builder_cache_object] => Array
                (
                    [0] => Array
                        (
                            [key] => advagg_file_builder_64a33c0ca0ec1d5af75eac8e7d6b5d86
                            [bundle_contents] => Array
                                (
                                    [sites/default/files/advagg_css/css_c7ab3c8f60caffae72a6add426147964_0.css] => Array
                                        (
                                            [0] => modules/book/book.css
                                            [1] => modules/node/node.css
                                            [2] => modules/system/defaults.css
                                            [3] => modules/system/system.css
                                            [4] => modules/system/system-menus.css
                                            [5] => modules/user/user.css
                                            [6] => sites/default/modules/bible_field/bible_field.css
                                            [7] => sites/default/modules/cck/theme/content-module.css
                                            [8] => sites/default/modules/filefield/filefield.css
                                            [9] => sites/default/modules/footnotes/footnotes.css
                                            [10] => sites/default/modules/glossary/glossary.css
                                            [11] => sites/default/modules/mollom/mollom.css
                                            [12] => sites/default/modules/simplenews/simplenews.css
                                            [13] => sites/default/modules/typogrify/typogrify.css
                                            [14] => sites/default/modules/wysiwyg_imageupload/plugins/imgupload/imgupload.css
                                            [15] => sites/default/modules/cck/modules/fieldgroup/fieldgroup.css
                                            [16] => sites/default/modules/views/css/views.css
                                        )

                                    [sites/default/files/advagg_css/css_f2884fcc99e132712e76bb6de584208a_0.css] => Array
                                        (
                                            [0] => sites/default/modules/wysiwyg/editors/css/tinymce-3.css
                                            [1] => sites/default/modules/jquery_ui_dialog/css/jquery_ui_dialog-dialog/jquery_ui_dialog.css
                                            [2] => sites/default/modules/jquery_ui_dialog/css/jquery_ui_dialog.main.css
                                        )

                                    [sites/default/files/advagg_css/css_1ff36e097b0752f8304d03e0980d88b3_0.css] => Array
                                        (
                                            [0] => sites/default/modules/imagefield/imagefield.css
                                            [1] => sites/default/modules/link/link.css
                                        )

                                    [sites/default/files/advagg_css/css_4329a942c3351bedea2572f3820acd9e_0.css] => Array
                                        (
                                            [0] => sites/default/modules/finder/finder.css
                                            [1] => sites/default/themes/analytic_modified/style.css
                                            [2] => sites/default/themes/analytic_modified/local.css
                                        )

                                )

                        )

#9

Posted by droopy on April 12, 2011 at 9:57am

CSS compression is on, Preserve CSS is disabled. Yes, Analytic uses the defaults.

I've attached an image of the style information from firebug about the fieldset.collapsible legend a selector.

It's beyond me to work out what file may have overridden anything.

AttachmentSize
firebug.jpeg 94.93 KB

#10

Posted by mikeytown2 on April 12, 2011 at 10:07am
Title:Corrupted CSS background image properties » CSSTidy - Corrupted CSS background image properties
Component:Miscellaneous» CSS Compression

Preserve CSS is disabled... that is the issue most likely. CSSTidy is not as reliable with this turned off but it does compress more. Switch it back to the default (checked), and go here admin/settings/advagg/config and run a cache rebuild.

#11

Posted by droopy on April 12, 2011 at 10:35am

I'll try that, but before I saw it I added no repeat to html.js fieldset.collapsible legend a in system.css:

html.js fieldset.collapsible legend a {
  padding-left: 15px; /* LTR */
  background: url(../../misc/menu-expanded.png) 5px 75% no-repeat; /* LTR */
}

That seems to have fixed the problem.

#12

Posted by mikeytown2 on April 12, 2011 at 10:40am

html.js fieldset.collapsible legend a {
  padding-left: 15px; /* LTR */
  background: url(../../misc/menu-expanded.png) 5px 75% no-repeat; /* LTR */
}

Is what comes with drupal.
http://drupalcode.org/project/drupal.git/blob/8636b1234c84a07f0f087ca5d6...

That was missing?

#13

Posted by droopy on April 12, 2011 at 11:03am

Just the "no repeat". It's also missing in the 6.20 version that you linked (line 322).

#14

Posted by mikeytown2 on April 12, 2011 at 11:08am

line 319 has it (collapsible vs collapsed)

#15

Posted by droopy on April 12, 2011 at 12:36pm

I undid the change to system.css, selected Preserve CSS, and rebuilt the cache. It works well now. So I have a choice BETWEEN a minor change to system.css + disabled Preserve cache AND keep system.css as is + enable Preserve CSS.

#16

Posted by mikeytown2 on April 12, 2011 at 7:40pm
Title:CSSTidy - Corrupted CSS background image properties » CSSTidy - Corrupted CSS background image properties when "Preserve CSS" is disabled
Status:active» closed (won't fix)

This is expected behavior. CSSTidy is a library that I use. I'm open to patches that fix errors in CSSTidy but I don't want to be the lead on improving it. Bringing in other options for CSS compression is a higher priority.

nobody click here