Active
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Apr 2011 at 20:05 UTC
Updated:
4 Aug 2014 at 16:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lsolesen commentedAre you still struggling with core issue blockers?
Comment #2
dave reidI'm not struggling against them - they can be worked around.
Comment #3
damienmckennaComment #4
bago commentedI have latest D7 so #1067120: Missing hook_taxonomy_term_view() or hook_entity_view() when viewing a term is fixed and I backported the latest patch from #1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views but I'm still not able to alter the title for the forum taxonomy term pages, so maybe the 2 issues are not the only blockers.
Comment #5
bago commentedOps, I'm sorry.. I just saw I backported #148145: "Forums" title is not localized that is only related to #1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views that still doesn't have any D8 patch attempt.
Comment #6
bago commentedOK, I fixed it locally, by following this steps:
1- backported #1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views to D7 (returning a render array, too, and not the latest D7 patch available there).
(1bis- cloned the forum module in sites/all/modules so to be able to patch it without patching core.)
2- added this code forum_page() (similar to what taxonomy_term_page does)
This way my forum pages are succesfully using titles and metas defined in metatag for the forum taxonomy.
The patch I attach is for the forum module and is based on 148145-forum-page-cleanup-d7.patch (comment #55 from #1122808: hook_entity_view and hook_taxonomy_term_view() are not implemented on forum term views).
I also tried to simply workaround the forum issues in metatag module with no success, so I ended branching the forum. I don't know if there is a best practice for this, but maybe the best thing would be to create a forum project on drupal.org and put there the fixed forum module so that people that needs it fixed on D7 can simply download the module and it will take precedence on the core module)...
Comment #7
damienmckenna@bago: That's great sleuthing and I really appreciate the work, but can you please post this over on #1662668: Support forum pages until forums supports hook_entity_view()? Thanks :)
Comment #8
bago commentedDone!
Comment #9
damienmckennaWill follow-up with this after 1.0 is out.