remove entity_exportable_schema_fields() from hook_schema() implementations

I think it's the same as #1099812: Docs on how to prevent fatal error when using entity_exportable_schema_fields() from hook_update_N() -- and indeed the solution is not to use entity_exportable_schema_fields(), but to copy it.

Indeed, that's problem. I guess the helper becomes useless then :(

Patch attached. Please review.

Note that I left the function there, so that modules making use of it right now don't suddenly break.

thanks, committed.

+++ b/entity.module
@@ -590,14 +590,21 @@ function _entity_modules_get_default_types($modules) {
+ * Warning: Do not call this function in your module's hook_schema()
+ * implementation or update functions. It is not safe to call functions of
+ * dependencies at this point. Instead of calling the function, just copy over
+ * the content.
+ * For more details see the issue http://drupal.org/node/1122812.
  */
 function entity_exportable_schema_fields($module_col = 'module', $status_col = 'status') {

If you don't want others to call this function, then rename it to a private function. That will not only make clear that no one should call it, but also prevent anyone from not updating potential calling code.

Powered by Dreditor.

As noted above:
>Note that I left the function there, so that modules making use of it right now don't suddenly break.

That way we prevent an update and dependency nightmare for user. So for now, I think it is best to stay with the name.