Remove the restriction on regular expression special characters in the words blacklist.

CommentFileSizeAuthor
#6 _webform_validation_1122982_6-D6.patch1.83 KBDrewMathers
#4 webform_validation_1122982_blacklist.patch1.37 KBliam morland
#4 webform_validation_1122982_preg_match.patch1.94 KBliam morland
#2 _webform_validation_1122982-2.patch1.3 KBDrewMathers
#1 _webform_validation_1122982_1.patch1.33 KBDrewMathers

Comments

DrewMathers’s picture

DrewMathers commented
Status: Active » Needs review
StatusFileSize
new _webform_validation_1122982_1.patch1.33 KB

Here is a patch that escapes any regular expression special characters in the blacklist words list.

DrewMathers’s picture

DrewMathers commented
StatusFileSize
new _webform_validation_1122982-2.patch1.3 KB

Replaced my ugly PHP version detection hack.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.x-1.4 » 7.x-1.x-dev
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Fixed
StatusFileSize
new webform_validation_1122982_preg_match.patch1.94 KB
new webform_validation_1122982_blacklist.patch1.37 KB

This change is backward-incompatible for anyone using the fact that regex characters were not escaped.

Fixed in ebdf5e8a509ee759f59c89c0311de116a8951e26. Code tidied up in ed64823390bea7559d55e81b19a65d75c9cfda03. Patches attached.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
DrewMathers’s picture

DrewMathers commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new _webform_validation_1122982_6-D6.patch1.83 KB

D6 backport patch

The following pending backports have a dependency on this one:
#1162054: Words blacklist matches to patterns instead of words
#1082134: Pattern validator

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Needs review » Closed (fixed)

Drupal 6 is no longer supported.