Closed (outdated)
Project:
Taxonomy Menu
Version:
6.x-2.9
Component:
Sync
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
11 Apr 2011 at 07:56 UTC
Updated:
11 Mar 2016 at 14:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dstolThis is something that's bothered me in general. I hate that taxmenu just throws all of it's configuration into the variables table.
In this situation, there's a huge potential for hundreds of variable_sets and later on hundreds of variable_gets. A real performance sink.
Marking as needs work. I think there's a better solution here. Also, there's a fair amount of coding standards problems in this patch.
Powered by Dreditor.
Comment #2
agileware commentedSubscribe. (Note to self: roll a patch for D7)
Comment #3
psycle interactive commentedHave re-created the patch to try and fix the code styling issues and improve the use of variable_get/_set functions. In the patch only 1 variable is used to store the settings for including/excluding a taxonomy term in the menu, meaning that it does not need to do a variable_get/_set for each taxonomy term.
I have created a patch for both the 6.x-2.x branch and the tag 6.x-2.9, because after creating the patch for the 6.x-2.x branch, i got errors when trying to apply it to the 6.x-2.9 tag. due to changes to comment styling between the branch and the tag.
Any feedback is welcome and i will look into a D7 patch when i have some time to do it.
Comment #5
psycle interactive commentedUploading the 6.x-2.9 patch again so that this issue can be closed as resolved. The failed patch was for the 6.x-2.x branch, as explained in the comment.
Comment #6
no_idea_yet commented#3: hide_from_menu_6.x-2.x-1123152-3.patch queued for re-testing.
Comment #7
Michael Zetterberg fd. Lopez commentedWith the patch in #5 it is not possible to delete terms from a vocabulary.
Attached is a patch that allows delete of taxonomy terms. Apply to 6.x-2.9.
Also attached an interdiff to #5.
Comment #8
johnvI'm not sure this is the right approach.
There are several other issues that deal with 'syncing' the menu item properties with the taxonomy terms.
To mention just one: #1485198: Menu_links properties (parent plid, hidden, weight) not saved after node creation/update/deletion (in _taxonomy_menu_save() )
IMO the right approach would be to support the 'hidden' property of the corresponding menu item, instead of removing the tree.
Comment #9
johnvComment #10
handell commenteddelete the specific menu item from the database.
the table is called 'ryd_taxonomy_vocabulary' in your phpMyAdmin
the mysterious menu item you want gone should be in there.
Mine was called 'Taxonomy Terms'
Comment #11
dstolThe Drupal 6 version is no longer supported