Closed (outdated)
Project:
D7 Media
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Apr 2011 at 14:25 UTC
Updated:
25 Jan 2019 at 20:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
james.elliott commentedpatch attached
Comment #2
james.elliott commentedComment #3
JacobSingh commentedRTBC. It works fine. It's a step backwards though in terms of DRY. Pretty much every JS framework seems to have one of these, I think I stole this one from YUI. I suppose being "standard" is more important than being right though :)
Maybe we should try to get a namespace function into core.
This is an interesting thread on the topic (sorta):
http://stackoverflow.com/questions/527089/is-it-possible-to-create-a-nam...
Regardless, I defer to you on pretty much all JS matters, just go for it.
Comment #4
effulgentsia commentedLooks like this has been rolled into #1139514: Overhaul the media browser code to not use an iframe, and be more understandable, maintainable, and extendable. Please re-open this issue if you'd like it committed ahead of the other issue.
Comment #5
gilgabar commentedThe issue this was to be rolled into has been closed as won't fix, so reopening this as it is still a worthwhile change.
The patch in #1 needs to be updated for the current code base and there is a stray kpr() that should be removed.
Comment #6
chris matthews commentedClosing this issue as outdated. However, if you think this issue is still important, please let us know and we will gladly re-open it for review.
sincerely,
- the Drupal Media Team