Intital D7 port

hey,
thanks for sharing this, just what i am looking for. unfortunately i am have not been able to get this to work.
i have added this into my landing page "thank you" page but for some reason when i look at the page source it looks like this:

 <!-- Google Code for Leed Conversion Page -->
<script type="text/javascript"></script><script type="text/javascript" src="http://www.googleadservices.com/pagead/conversion.js">
<!--//--><![CDATA[// ><!--


//--><!]]>
</script><noscript>
<div style="display:inline;">
<img height="1" width="1" style="border-style:none;" alt="" src="http://www.googleadservices.com/pagead/conversion/969411295/?label=U9FiCNnh3gIQ35WgzgM&amp;guid=ON&amp;script=0" /></div>
</noscript>  </div>

instead of this

<!-- Google Code for Leed Conversion Page -->
<script type="text/javascript">
/* <![CDATA[ */
var google_conversion_id = 969411295;
var google_conversion_language = "en";
var google_conversion_format = "3";
var google_conversion_color = "ffffff";
var google_conversion_label = "U9FiCNnh3gIQ35WgzgM";
var google_conversion_value = 0;
/* ]]> */
</script>
<script type="text/javascript" src="http://www.googleadservices.com/pagead/conversion.js">
</script>
<noscript>
<div style="display:inline;">
<img height="1" width="1" style="border-style:none;" alt="" src="http://www.googleadservices.com/pagead/conversion/969411295/?label=U9FiCNnh3gIQ35WgzgM&amp;guid=ON&amp;script=0"/>
</div>
</noscript>

i also test conversions and nothing was recorded in adwords.
would love some help if you can.

@das-peter

How could I use this module you wrote for D7 on the 'Completion message' checkout pane of Commerce ?

For the record, commerce_google_analytics is for adding Google Commerce tracking - which is different from AdWords conversion tracking, which is what this module is about.

Here is the module from the original post verbatim but as a patch. Can we get a D7 branch of the module to work against please?

To make life easier for now, I've created a sandbox with the D7 branch at http://drupal.org/sandbox/mrfelton/1517042

A couple of things about this:

1) Im my sandbox I have switched hook_page_build for hook_page_alter which ensure that it's run a little later in the cycle.

2) You can use this on a drupal commerce thank you page by creating a rule that acts on the 'Drupal is initializing' event with a php condition containing:

return arg(0) == 'checkout' && is_numeric(arg(1)) && arg(2) == 'complete';

This might not work if you have custom redirects or have customized the checkout process in other ways, but it will work with stock Drupal Commerce.

It would be better if we could use the 'Completing the checkout process' event instead, but this would require reworking things slightly so that the code is inserted properly on the page load after completing the process, ie. the one that loads after completing the checkout. Only way I can think of is setting a temporary cookie.

3) It might be better to use drupal_add_js rather than printing the js in a theme function. A bit like ho I did it in #442930: Support for adwords conversion tracking.

How is the sandbox code working?

Is it ready to use in a production site?

Thanks.

We are using it in production without issue.

Thank you mrfelton, I'll do it too

for non-programmers - how do I use the sandbox - is this a module? how do I download it?

@axon you'll need to clone it via git, but for your convenience, I've attached a zip.

A D7 branch has been created. Thank you for the patches and upgrades. I modified some things that I thought needed it.

Wonderful! When would it show up on the project page?

The dev branch seems to be working. The beta should be removed or merged because it appears to be identical to 6.x-1.3

I am closing this issue since the intent of the original request has been meet. I agree about the documentation and that will be the next thing I tackle after fixing the code related issues in the queue.