Closed (works as designed)
Project:
Social Share
Version:
7.x-2.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Apr 2011 at 18:21 UTC
Updated:
12 Feb 2015 at 18:48 UTC
Jump to comment: Most recent
Comments
Comment #1
witchcraft commentedi think that for 7.x-2.x branch would be nice to use the file upload core function to upload icons .
i am a little newbie with all this website building staff , as far the module will be easy to use more ppl will use it.
sorry for my english.
Comment #2
willvincent commentedHmm.. this is an interested thought. I've just begun the 2.x branch, I might consider it. Although I do still lean toward the preference of having this all managed by CSS through your theme, since that's really the right way to do it.
Comment #2.0
willvincent commentedRoadmap update 8/10/2011
Comment #2.1
willvincent commentedRoadmap Update 2: 8/10/2011
Comment #2.2
willvincent commentedRoadmap update #3: 8/10/2011
Comment #3
witchcraft commentedi understand your concept , since its hard to me write all in english i will try to sketch some ideas about the front-end Admin UI in the next few days .
this maybe evan deal with #1245054: Additional Social Networks! .
Comment #4
bigmonmulgrew commentedHow about you make it configurable to display text share links or to use images.
Basically next to the checkbox to enable each one you would have a checkbox to enable the image. I'm tempted to attempt it myself although I have no experience editing modules or writing for drupal. This is quite a simple module though worth a try
If I get anything working I'll post it here
Comment #5
willvincent commentedThere is already a config option in the 2.x branch that allows display of the links as icons.
However, no other 'display as an image' functionality will ever be included. This module has always been intended as a simple way to get basic share links onto a piece of content. That's it, that's all. And to aid front end developers, by default no CSS is added to those links, so that there is nothing that has to be undone to do whatever needs to be done for theming.
end of discussion.
Comment #6
greenbank commentedI expect exposing this to views will solve this issue, but it would be nice to be able to specify a normal space for the link suffix, or none at all.
(For example, I need to use this in a block in a sidebar, but didn't see a way, other than editing the module itself, to change the '#suffix' from a non-breaking space.)
Thanks for a handy module, this is exactly as bare-bones as I like these things to be.
Comment #7
willvincent commentedMaybe I don't understand what you're after, but the module _does_ provide a block..
Comment #8
wrongway_001 commented-Additional social network - would be awesome if Pintrest could be added
Comment #9
Diane Bryan commentedIt would be great if someone could put together a FAQ or TIPS for this module that answers the most common hiccups that people encounter. (You know the ones... the forums are peppered with them)
Thus, even though people could choose a thousand ways to customize the share icon, if they were shown one way, they could take it from there.
And even though "everybody" knows that controlling or customizing the text that is shared is beyond the module's scope, it would be golden to include some helpful advice about where to turn for such control.
And so on.
To me, this would be a big step forward for v2.
Comment #10
willvincent commentedAre you volunteering? :)
Comment #11
walidvb commentedI was about to start writing a custom module for something slightly different(i have multiple sites where I have nodes representing people/artists, and I need to list links to their social network pages), and what i was mostly interested in was to add this as a field, and never touch the display.
While your module has a different function, I would be curious to know why you don't want to offer a set of icons, that the user could choose from, or override in his theme? That to you it is no priority, sure, but that it will never be included makes no sense to me.
Comment #12
willvincent commentedTwo things. One, I'm a pretty firm believer in not adding to the list of CSS that has to be overridden to theme a site. Themers have enough to worry about without having to override styles from YET ANOTHER module.
If you're not familiar with the angst they have about this issue, you really ought to listen to Morton talk about it.
Secondly, despite my believe of not adding more css for themers to deal with overriding, and at risk of being (verbally) attacked by Morton or another angry themer, I've already added default icons to the module in the 2.x branch.
Comment #13
walidvb commentedFair enough. One could imagine a configuration option such as 'disable module icons', though.
The option of being able to enable a module, select node types, select(or upload) icon set and be done with it still seems great to me.
Thanks for the module, still, saves a lot of time, and is indeed easily themable.
Comment #14
willvincent commentedComment #14.0
willvincent commentedRoadmap update #4: 8/10/2010
Comment #15
kscheirerNice work following through on your planned roadmap!
@wrongway_001 -Pinterest is included now.
Comment #16
willvincent commented