When cloning, if the modules, libraries or themes directory are non-empty the files get the setgid bit set too instead of just subdirectories.

It looks like none of the directories should be chmod recursively. But should have the functionality of "find themes -type d -print0 | xargs -0 chmod 2775"

CommentFileSizeAuthor
#1 change-chmod-recursion-1124154-1.patch1.01 KBjoestewart

Comments

joestewart’s picture

joestewart commented
Status: Active » Needs review
StatusFileSize
new change-chmod-recursion-1124154-1.patch1.01 KB

git format-patch style patch for 7.x-2.x attached for review.

omega8cc’s picture

omega8cc commented
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community

The patch works as expected. Thanks!

anarcat’s picture

anarcat commented
Status: Reviewed & tested by the community » Needs work

Okay wait here. With this patch *no* directory gets recursively chmod'd. Why don't we ditch that completely instead of having a blacklist that blacklists everything?

omega8cc’s picture

omega8cc commented

Good catch.

But maybe there was a reason we did it before that way? I can only recall from discussions with Vertice, that it was related to the remote stuff permissions issues, so maybe we should test it with remote servers first?

joestewart’s picture

joestewart commented
Version: 6.x-1.0-rc7 » 6.x-1.1

It looked to me that it was just a way of avoiding the recursive chmod on files problem, but didn't address recursive chmod on directories - http://drupal.org/node/874716#comment-3294098

After 1.2 is released I'll try to submit a cleanup without recursion for 1.x and have mostly worked through a method for 2.x with recursion that will go back to "maintaining permissions on existing directories"

That will give more time to test on remotes too.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Version: 6.x-1.1 » 6.x-2.x-dev

Cross-referencing: #1647830: Incorrect ownership of directories under sites/example.com/private/files/

helmo’s picture

helmo commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

The 6.x-2.x branch will go EOL along with Drupal this week. So I'm closing
this issue. If it remains a confirmed issue in 7.x-3.x, feel free to re-open,
or better yet, create a new issue referencing this one.

PS: some more recent discussion: #2616426: Add 'fix permissions' task