First, let me say that this module is outstanding. I can't imagine why this kind of functionality hasn't been added to core.

However, I've found one flaw that I'd like to see fixed, or at least addressed. Generally when I do a search, I expect the search to apply when I press ENTER. Unfortunately, pressing ENTER with the Module Filter search field focused causes the page form to submit, refreshing the page and destroying the search results.

Thus, I have to consciously avoid pressing the ENTER key to ensure that my search isn't voided, going against years of ingrained muscle memory.

I understand the advantage of having the form submit itself when pressing ENTER, since you won't always have the Save Configuration button visible on screen. However, the ENTER key will also submit the form whenever a module's checkbox is focused, which is going to be the case anyway after any change is made to the configuration.

If you absolutely have to keep ENTER on the search field available as a form submission method, could you please add an option in the Module Filter config page that will make ENTER into a no-op in that field?

Thanks for your consideration.

CommentFileSizeAuthor
#2 block_enter_key-1124218-7.x-1.6.patch1.18 KBjyee

Comments

ayalon’s picture

This is a real usability draw back. I think it could be easily fixed by bindung the enter keystroke to Javascript an block it.

jyee’s picture

Version: 6.x-1.6 » 7.x-1.6
Status: Active » Needs review
StatusFileSize
new1.18 KB

Agree, this really is a usability failure. Here's a patch to block the form submission for the D7 1.6 version.

greenskin’s picture

Version: 7.x-1.6 » 7.x-2.x-dev

Moving to 7.x-2.x to be followed by 7.x-1.x and 6.x-1.x.

greenskin’s picture

petsagouris’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.