I just did a 5.0 upgrade and now I want to use the sIFR module. I used to use sIFR in my theme but this is a much more rational approach.

Unfortunately the sIFR module is not working on my site for some unknown reason. I am using the same downloaded archive that I just installed on another site where it is working perfectly.

This is what I see on the sifr admin page (sometimes once, sometimes twice):

The sIFR library is in not installed correctly. Please download from http://www.mikeindustries.com/sifr/ and place in Drupal's modules/sifr/ directory.

Of course, I did this. I also looked around for other issues and found issue 55836 which claims you need only two files. I've tried unpacking the whole archive there, and I've tried unpacking just the two .js files there.

Looking at my page source revealed the following sifr-related lines:

<script type="text/javascript">var dest = "&dbldestination=admin%2Fsettings%2Fsifr";</script>

Which looks pretty amazingly wrong of course...

Both this site and the site it's working on are using PHP 4.4.x.

CommentFileSizeAuthor
#1 sifr.module.findsifr.patch1 KBhyperlogos

Comments

hyperlogos’s picture

hyperlogos commented
Status: Active » Needs review
StatusFileSize
new sifr.module.findsifr.patch1 KB

I just installed sIFR module on another site upgraded from 4.7.4 to 5.0 and I have the same problem there. Tried just sifr.js and sifr-addons.js with no luck, tried expanding the whole archive in the sIFR module dir and still no luck. moved the sifr module from sites/all/modules to sites/default/modules and the error went away for one reload. Clicked on modules screen and it came back with the error twice (suppressed once on the prior load?) Then I disabled the module and still got the error on the resulting page. Reloaded the module and did not get the error. I re-enabled the module and got the error again (now installed in sites/default/modules).

Ahh, finally, I find the problem. It lies here:

function sifr_find_sifr(){
  $moddir = drupal_get_path('module', 'sifr');
  $files = file_scan_directory($moddir, 'sifr\.js', array('.', '..', 'CVS', '.svn'), 0, TRUE, 'filename', 1);
  // the first one is the shallowest, return that one
  $file = array_shift($files);
  $file->dir = substr($file->filename, 0, strlen($file->filename) - strlen($file->basename) - 1);
  variable_set('sifr_dir', $file->dir);
  return $file->dir ? $file->dir : FALSE;
}

The problem is the DEPTH specified to file_scan_directory. It is 1. It should be 0, or the documentation needs to specify that sIFR needs to be installed to a subdirectory of the module dir. There's no reason to require that. therefore I am including a patch here that changes it to 0.

Deyan’s picture

Deyan commented

Have the same problem as you, but the patch doesn'e seem to work for me - tried several times. working on ver. 5RC1. So is this the way the code should look (i'm trying to apply the patch manually but with no success so far)?:

$files = file_scan_directory($moddir, 'sifr\.js', array('.', '..', 'CVS', '.svn'), 0, TRUE, 'filename', 0);

so if this is supposed to be the only change then for me it won't fix the problem. Any suggestions? Am I not getting things straight?

Deyan’s picture

Deyan commented

got things working now - http://drupal.org/node/52915#comment-136159

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Marking as dupe of http://drupal.org/node/52915
Also remember to install contributed modules in /sites/all/modules/sifr in Drupal 5.0. Only Drupal core stays in /modules.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Closed (duplicate)
hyperlogos’s picture

hyperlogos commented

Don't forget, I might also want to install modules in /sites/whatever/modules... so they can be site-specific. Also modules should still work if they are installed into /modules, you're just not supposed to put them there... It's not prohibited, just counterindicated.