Download & Extend
Vote Up/Down » Issues

format_plural reports plural for singular down vote

Posted by elky on April 12, 2011 at 7:35am
Project:Vote Up/Down
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:elky
Status:closed (fixed)

Issue Summary

sending absolute value to format_plural avoids this

Login or register to post comments

Comments

#1

Posted by elky on April 12, 2011 at 7:36am
Status:active» needs review
AttachmentSizeStatusTest resultOperations
format_plural_absolutes-1124448-1.patch1.6 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch format_plural_absolutes-1124448-1.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.View details

#2

Posted by elky on April 12, 2011 at 10:26pm

Rerolled patch to get rid of the other changes not relevant to this issue

AttachmentSizeStatusTest resultOperations
format_plural_absolutes-1124448-2.patch974 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch format_plural_absolutes-1124448-2.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.View details

#3

Posted by marvil07 on April 17, 2011 at 11:51pm
Status:needs review» fixed

Good catch!

The point is that if format_plural receives a -1 it takes the plural form, WTF?

Patch committed to 6.x-2.x, 6.x-3.x and 7.x-1.x.

Thanks

#4

Posted by elky on April 18, 2011 at 10:46pm

Glad to be of assistance!

I'm actually at some point going to poke core with a patch (or you can if you like, I don't mind!) The linguistic nuances of format_plural are somewhat contentiously debated though.

#5

Posted by elky on April 19, 2011 at 7:48pm

As I expected, it's not an easy fix to put through core. http://drupal.org/node/1131926

#6

Posted by System Message on May 3, 2011 at 7:51pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here