BASIC - a modern HTML5 and CSS3 theme [#1124944]

The URL is http://drupal.org/sandbox/polle93/1124766

I developed this theme because I was searching a clean, simple, valid and modern theme and I didn't found one that matched my requests.

I'm using this theme at the moment on 2 sites and I thought it would be nice to share it with others.

I am completely new to developing themes for Drupal and the fact that this theme is for Drupal 7.x didn't make it easier.

So please tell me if I made errors or if there better ways.

Comment	File	Size	Author
	screenshot.png	40.4 KB	Anonymous (not verified)

Comments

Comment #1

rolf vreijdenberger commented 13 April 2011 at 13:02

polle,
I'm not a reviewer, but allow me to give you some well meant feedback:

- your description is not well written: "It's not entirely finished and there are still some bugs, but it can already be used." what does that mean? for me this means that it's not production grade, buggy and incomplete.
- people want to know what to expect: what does your theme do other than being clean, simple, modern and valid? Which, apart from being valid, are all subjective terms.
- what are the positive things about your theme, why would I use it?
- is your code screened with the "coder" module and does it adhere to the standards?

please provide this and more info, get the bugs fixed as much as possible (obviously you know there are bugs, otherwise you wouldn't mention them :)) and then reapply.

I hope you can do something with this and wish you luck with your project

cheers!

Comment #2

Anonymous (not verified) commented 13 April 2011 at 13:18

Thank you for your comment.
I'm going to work on the mentioned points.
I thought i can publish beta themes because a lot of drupal 7 modules are still in a developing state.

PS:
It's not a bug, it's a feature that isn't added ;)

Comment #3

Anonymous (not verified) commented 13 April 2011 at 15:58

Status:

Needs review

» Needs work

Comment #4

laura s commented 13 April 2011 at 17:26

A general note: It's something of a misnomer to declare as html5 a theme that includes no html5 markup.

Some issues I see:

html.tpl.php

* Why $global_user ?
* Do you want to break Drupal core's RDFa support?
* You are missing helpful region declarations: http://drupal.org/update/themes/6/7#closure
* No print $head; ?
* require meta.html - Certainly odd. You can manually add meta in html.tpl.php, or insert it using the Drupal API via template.php.

page.tpl.php

* The $link['href'] code seems unecessary. There are existing ways to add classes to menus etc.

.info file

* See notes about regions

See http://drupal.org/coding-standards about formatting and other guidelines.

Personally I would prefer to see the theme do what it declares itself to do, with html5 markup at least in the templates already created. I'm not sure what the policy is on this.

In sum, this theme has a lot of not-best practices and definitely needs work, but there is no insecure code, afaict. Approval ready?