The variable set function has a typo.... Should be resource instead of system.

CommentFileSizeAuthor
#8 0001-Variable-Delete-patch-for-system-resource.patch5.16 KBkylebrowning
#6 1125168.patch4.27 KBrobloach
#3 variables.patch3.09 KBrobloach

Comments

kylebrowning’s picture

kylebrowning commented
Status: Active » Postponed (maintainer needs more info)

Where? what line? What file?

robloach’s picture

robloach
he/him
commented
Version: 7.x-3.x-dev » 7.x-3.0-rc1
Status: Postponed (maintainer needs more info) » Fixed

Ah, already fixed in 3.x-dev :-) ... rc1 had _system_service_set_variable instead of _system_resource_get_variable.... Yay! Services 3.x rules my face!!!!!

robloach’s picture

robloach
he/him
commented
Title: Variable Set typo » Variable clean up
Version: 7.x-3.0-rc1 » 7.x-3.x-dev
Category: bug » feature
Status: Fixed » Needs review
StatusFileSize
new variables.patch3.09 KB

Well, what about this? Adds a "del_variable" action, makes the $default argument of variable_get optional and removes the proxy functions and just calls the methods directly.

kylebrowning’s picture

kylebrowning commented

Tests pass, looks good, can you add a test for the new del_variable action

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Needs work
robloach’s picture

robloach
he/him
commented
StatusFileSize
new 1125168.patch4.27 KB

I think I'm rage quitting on how long running tests take..... #913086: Allow modules to provide default configuration for running tests

kylebrowning’s picture

kylebrowning commented

Yeah Rob, its SUPER annoying. 6.x was much faster. Lets start a revolution!

Thanks for the patch, running System Resource tests now :P

kylebrowning’s picture

kylebrowning commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs work » Patch (to be ported)
StatusFileSize
new 0001-Variable-Delete-patch-for-system-resource.patch5.16 KB

The tests dont pass, b/c you need to enable the del_variable method for the system resource, attached patch fixes this, and all tests pass so Im comitting and marking as patch to be ported.

kylebrowning’s picture

kylebrowning commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.