I have created a module for integration with domain access, which extends capabilities for use with Drupal core. It is sandboxed here.
It has been run though the strict coder module with everything passing with exception to the deprecated CVS tag.
Hoping to get this into a full project once application is approved. I also wish to contribute further modules in the future. Some are already partly ported for more 'general' use cases which will be of some value to the community at large.
Thanks for your time in looking at this application. Any questions/issues, please ask.
Kind regards,
Barry Fisher
Real Life Design
Comments
Comment #1
svendecabooterSince you mention it, you could already go ahead and remove the deprecated CVS tags.
Also, please remove the LICENSE.txt file from your code, as that's a file that gets added automatically by the drupal.org packaging script.
Comment #2
svendecabooterComment #3
barry_fisher commentedThanks @svendecabooter. I meant that I deliberately left out the CVS tags but the coder module hasn't yet been updated to remove that as a requirement after the d.o git migration.
License text file has now been removed.
Any idea how long these applications take so I can plan things?
Thanks again,
Barry
Comment #4
svendecabooterWe are suffering from a big backlog, so I fear the application could take a while. But there's no official timeframe to be given, so just wait & see i'm afraid.
I have reviewed your module and couldn't find any big problems with it. There are 2 minor issues that i stumbled upon, for which i created an issue on your sandbox.
I'm setting this to reviewed for now, so someone with proper privileges can give you full project access. I suggest you try to get those minor issues fixed in the meanwhile.
Comment #5
svendecabooterComment #6
barry_fisher commentedThanks for the info Sven and for your time looking at this.
I've addressed the couple of issues and committed the changes back.
I will patiently await approval for this module.
Comment #7
agentrickardThis is ready to be approved. The module was originally developed in the DA issue queue. Nice addition.
Comment #8
dave reidI asked agentrickard, the Domain module maintainer to give this a final look. With his approval, I'm approving this Project application. reallifedesign, enjoy promoting your sandbox to a full module project! Be sure to subscribe to your module's issue queue to always be alerted to issues that other users file. Now that you have the ability to create full projects without review, make sure to take a little bit of time before each project to check to see if you can coordinate with an existing effort, or maybe put code in a sandbox first and ask for peer review. It is a pleasure to have you has a new, official contributor to Drupal.org!
Comment #9
barry_fisher commentedThanks Dave and Ken for approving this. I've now promoted the module and added it to the DA contrib list.