Description

This module allows you to upload an image in the menu-item's configuration form and use the image anywhere in your theme. This is useful if you want to display an image - that is related to a menu entry - somewhere in your theme (header, navigation).

The uploaded image is available at the template layer in a variable called "$menu_image" along with some meta data. This module does not have any effect unless you know how to use the generated variable in your theme.

This module is Inspired by, similar to and initially based on Menu Icons, but it allows you to use the attached image anywhere in your theme, not only as a menu icon.

Discussion about similarity to Menu Icons (http://drupal.org/node/1125338)
Project page (http://drupal.org/sandbox/aminalid/1120770)

Comments

aminalid’s picture

aminalid commented

Bump!

aminalid’s picture

aminalid commented

Bump!
Its a really simple module, and is easy to review....

pillarsdotnet’s picture

pillarsdotnet commented
Component: new project application » module
Status: Needs review » Needs work
LICENSE.txt
Remove this file. It will be added automatically by the packaging process, as all drupal.org projects are assumed to be GPL.
README.txt
Correct INSTALATION to INSTALLATION.
File needs to be word-wrapped at 80 columns. Don't insert linefeeds into the middle of words; it makes the file very hard to read.
menu_image.info
You should rename your module "menuimage" so as to avoid overlapping with the namespace of the "menu" module.
menu_image.install
Comments should start with an uppercase letter, wrap at 80 columns, and end with a period.
menu_image.module
When enabling your module, I saw two PHP runtime warnings, as follows:
  • Notice: Undefined index: enable in menu_image_preprocess() (line 198 of sites/all/modules/menu_image/menu_image.module).
  • Notice: Undefined index: enable in menu_image_preprocess() (line 198 of sites/all/modules/menu_image/menu_image.module).
When running coder review, I saw additional warnings:
  • Notice: Undefined index: enable in menu_image_preprocess() (line 198 of sites/all/modules/menu_image/menu_image.module).
  • Notice: Undefined index: sites/all/modules/menu_image/menu_image.module in coder_page_form() (line 793 of sites/all/modules/coder/coder.module).
  • Notice: Undefined index: sites/all/modules/menu_image/menu_image.install in _coder_page_form_includes() (line 938 of sites/all/modules/coder/coder.module).
  • Notice: Undefined index: enable in menu_image_preprocess() (line 198 of sites/all/modules/menu_image/menu_image.module).
  • Notice: Undefined index: enable in menu_image_preprocess() (line 198 of sites/all/modules/menu_image/menu_image.module).
aminalid’s picture

aminalid commented

Thanks pillarsdotnet, i was beginning to loose hope getting a review :)
Will make the changes, and review the issues and come back.
Thanks again.

misc’s picture

misc commented

The applicant has been contacted to ask if the application is abandoned.

misc’s picture

misc commented

@aminalid answered that this application should still be active.

misc’s picture

misc commented

Contacted @aminalid again to check if this application is abandoned.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.