Increase maximum weight of a flexinode field
george@dynapres.nl - January 25, 2007 - 13:27
| Project: | Flexinode |
| Version: | HEAD |
| Component: | flexinode.module (core) |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
I'd like to see the maximum weight of a flexinode field to be increased from 10 to (a minimum of) 30 to accommodate (the manual sorting of) more fields.
| Attachment | Size |
|---|---|
| flexinode-increase-weights.patch | 323 bytes |
#1
The code needs to be tested a little, however simple it is :)
I like the feature though, a weigth of ten limits teh ability to weight to only 20 fields, this is a rather small amount. Increasing makes sense.
#2
Actually, a weight of 10 limits it to 10 flexinode fields (not 20) if you don't want the fields to be sorted above the title (if you use a negative weight). Personally I would opt for more than 20, it's easily changed, however. Maybe the weight should be more dynamically calculated depending on the number of fields declared.
#3
I think 30 is just fine.
Unless you feel an urge to make that dynamic increasing stuff, which sounds really nice (and usefull). But don't bother too much, IMO 30 will do fine.
#4
Sorry, I felt a terrible urge (I work with large field sets). This patch determines the maximum weight dynamically.
#5
The maximum weight is now calculated globally (across all content types). Maybe it's better to calculate a maximum for each individual content type.