Closed (fixed)
Project:
Mailchimp
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
14 Apr 2011 at 02:10 UTC
Updated:
26 Apr 2011 at 17:39 UTC
Jump to comment: Most recent file
Currently we record MC API errors like this -
watchdog('mailchimp', $q->errorMessage(), NULL, WATCHDOG_ERROR); IMO we should do this instead -
watchdog('mailchimp', 'MCAPI Error: %errmsg', array('!errmsg' => $q->errorMessage()), WATCHDOG_ERROR);
* This protects against potential injection attacks via MCAPI (results from MC API are external input after all).
* The MCAPI prefix (along with the existing $type value) also makes the original source of the error message clearer.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | mailchimp-1126742-watchdog_error_variables.patch | 2.63 KB | xurizaemon |
Comments
Comment #1
xurizaemonpatch
Comment #2
levelos commentedhttp://drupal.org/commitlog/commit/5104/f29ac870ff9ab5418e9a43089527e4c6...