Needs works, because still untested.

Patch uses file_prepare_directory() instead of drupal_mkdir(), and returns early in case of an error.

CommentFileSizeAuthor
#1 use-file-prepare-directory-1.patch1.47 KBamitaibu
user-file-prepare-directory.patch1.42 KBamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Needs review
StatusFileSize
new use-file-prepare-directory-1.patch1.47 KB

This patch is tested and seems to be working.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Needs work

Still needs some testing..

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Needs review

yap, seems to be ok (i had not configured my tmp file properly earlier).

corey.aufang’s picture

corey.aufang commented 
+++ less.module
@@ -61,12 +61,16 @@ function less_css_alter(&$css) {
+        watchdog('less', r('LESS could not create a directory in %dir'), $param);

Did you mean to call the r()?

I'm guessing that you meant to do it the same at the line above, and actually call t().

Let me know.

Powered by Dreditor.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Sorry, meant t().

corey.aufang’s picture

corey.aufang commented

Take a look at the latest dev.

I implemented your change with a slight addition of wrapping the drupal_set_message with a check for the same permission as dev mode uses.

corey.aufang’s picture

corey.aufang commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.