The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.This module seems to have a Javascript bug in Internet Explorer 8 and Safari that makes it not work.
Webpage error details in IE8:
Message: Expected identifier
Line: 3
Char: 41
Code: 0
URI: http://***.*********.com/sites/all/modules/admin_menu_dropdown/admin_menu_dropdown.js?C
It works in Firefox 3 but not in Safari on Mac. In Firefox no errors are thrown in the debugger.
Running:
Drupal: 6.20
Administration Menu: 6.x-1.6
Admin Menu Hider: Tried both 6.x-3.3 and 6.x-3.x-dev
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | admin_menu_dropdown_1127530_6.patch | 1006 bytes | Josh The Geek |
| #1 | admin_menu_dropdown_1127530_1.patch | 1021 bytes | Josh The Geek |
Comments
Comment #1
Josh The Geek commentedFound it: I use 'default' as a variable name, and it's a reserved word. Patch.
Comment #2
ejohnson commentedI appreciated the quick response and patch.
Those changes have fixed it in Internet Explorer 8, 7 and 6. Still works in Firefox 4. Tested and works in Google Chrome 10.
It still does not work in Safari 5. I'm not really sure how to debug in Safari though, as I seldom use it.
Comment #3
Josh The Geek commentedCommited and pushed. I moved the Safari incompatibility to #1128944: Incompatible with Safari.
Comment #4
theposse commentedHi, the same thing appears to be happening in the latest release of the 7.x branch on our website. Would you be able to verify that and if there is a patch that needs released, please do so? Thanks so much.
Comment #5
theposse commentedComment #6
Josh The Geek commentedThe (original) patch didn't apply for some reason even though the affected lines hadn't changed. Rerolled. Needs testing.
Comment #7
emcniece commentedConfirming #6 on D7.22, admin_menu_dropdown 7.x-3.0-alpha1 2011-01-02
Thank you!
Comment #8
izmeez commentedPatch in #6 applies to 7.x-3.x and works as expected.
Comment #9
izmeez commented[edit] My apologies for the noise, this comment was nonsense
I think this should be closed as a duplicate of #1221668: Breaks a lot of functionality when Aggregate JavaScript is on which is a more complete solution.
Comment #10
izmeez commentedI am restoring the status from the changes made with comment #9.
Comment #11
izmeez commentedI am closing this issue.The patch in #6 overlaps other issues and has been superseded by patches in separate issues.#1221668: Breaks a lot of functionality when Aggregate JavaScript is on that provides patch to module file.#1128944: Incompatible with Safari that provides patch to javascript.Comment #12
izmeez commentedAfter spending too much time on this I realized that this issue and #1128944: Incompatible with Safari are for 6.x-3.x-dev and issue #1221668: Breaks a lot of functionality when Aggregate JavaScript is on is for 7.x-3.x where it incorporates the changes in this issue and more.