I'm sure these issues are popping up all over the place these days, but is there a rough ETA for a Drupal 5 port of this module? We are using it on a site that we want to upgrade, but of course can't until all of the modules we use are Drupal 5-friendly.

CommentFileSizeAuthor
#10 invisimail-d5_0_0.patch3.89 KBalex_b
#7 invisimail-d5_0.patch3.92 KBowen barton
#5 invisimail.patch.txt2.04 KBdesignerbrent
#3 invisimail.txt132 bytesCrell

Comments

Crell’s picture

Crell commented

So for reference, I tried upgrading this module earlier today. Besides adding a .info file and commenting out the relevant parts of hook_help... it just worked out of the box. It wasn't affected by any other API changes at all. Sweet! :-)

I'm not sure what jjeff's plans are upgrade-wise, but for anyone waiting for an official 5.x release you need only wait as long as it takes to write a .info file (read: about 5 minutes).

lias’s picture

lias commented

Would you mind posting your .info file and the code you commented out for reference?
Thanks.
Lsabug

Crell’s picture

Crell commented
Status: Active » Needs review
StatusFileSize
new invisimail.txt132 bytes

A copy of the info file is attached. You'll have to rename it since .info is not an allowed upload type. :-(

Then in hook_help, comment out the following:

case 'admin/modules#description':
      // This description is shown in the listing at admin/modules.
      $output = t('Attempts to thwart spam-bots by encoding email addresses.');
      if (module_exist('invisimail')) {
        $output .= t(' <a href="%url">more help</a>', array('%url' => url('admin/help/invisimail')));
      }
      return $output;

Actually you don't even need to comment it out to get it to function. That code just becomes unused.

I am in a rush so can't roll a real patch, but since there's an info file attached I'll flag this as code needs review. :-)

lias’s picture

lias commented

Cool, thanks.

designerbrent’s picture

designerbrent commented
StatusFileSize
new invisimail.patch.txt2.04 KB

Attached in a patch file of Crell's changes to invisimail.module. Add the .info file with that and you will have the full 'upgraded' module.

ec’s picture

ec commented

Dear all,

I have successfully install invisimail following the tips provided in the thread but it doesn't work for me. Email addresses are still visible and readable in the page source :( ! Am I missing something ?

Thank you, kind regards,

Eric

owen barton’s picture

owen barton commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new invisimail-d5_0.patch3.92 KB

Here is a full patch:
* Includes invisimail.info file
* Removes modules page help text from invisimail.module
* Updates README.txt with Drupal 5 installation instructions

Tested and confirmed working - I think we are ready to roll here.

@ec - probably you were looking at an old node - old nodes need to be edited and saved for input filters to take effect

suit4’s picture

suit4 commented

The patch is working for me, too.

In case there is an url filter present, invisimail filter online works (for me), if it is applied before the url filter.
If the email address is already rednered as al mailto link, invisimail doesn't do anything.

Should that be mentioned anywhere in the readme?

ktrammel’s picture

ktrammel commented

I had no luck getting the patched files to install in Drupal. The patched module just isn't recognized on the modules page. suggestions?

alex_b’s picture

alex_b commented
StatusFileSize
new invisimail-d5_0_0.patch3.89 KB

The patch from #7 produces a subdirectory modules/invisimail/ containing invisimail.info within the invisimail directory.

This patch is the same as in #7 but should be applicable (to 4.7.x version) without a problem.

I did not test all functionalities of the module in 5.x. It installed smoothly, though.

Thanks for your work.

Christefano-oldaccount’s picture

Christefano-oldaccount commented

This post is off topic but nonetheless may be helpful. I recently built a new site and used Invisimail as I'd always used it before. It installed fine thanks to the fine patches in this thread, but for some reason I couldn't get it to work no matter what the load order was. Instead, I used the newish SpamSpan filter and had it working in seconds.

alex_b’s picture

alex_b commented

I use spamspan too, usually. But the CCK field "email" requires invisimail to obfuscate email addresses.

tignux’s picture

tignux commented

Tanks guys.

I hope we can have an official release in the future.

alex_b’s picture

alex_b commented

+1 for a 5.x release!

jmiccolis’s picture

jmiccolis commented

The patch from #10 is working fine for me. +1

Crell’s picture

Crell commented
Status: Reviewed & tested by the community » Fixed

Silly person that he is, jjeff gave me CVS access. I've committed the info file and patch. The tarball should show up soon. Yay!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)