By Flu on

Hi. I just installed Drupal version 5.0, along with several modules: Organic Groups, CCK, Views, TinyMCE, IMCE, and Advanced Front Page. I'm extremely impressed with the flexibility of Drupal and the associated modules thus far..well done all around. I am, however, having a small issue getting revisions to function.

I would like to enable revisions by default on blog entries. In order to attempt to accomplish this feat, I have gone into Content Types and put a check mark next to the "Create new revision" option of the "Blog Entry" type. Additionally, under the "Access Control" menu, I do have a check mark next to "revert revisions" and "view revisions" for the "authenticated users" type.

The above settings seem to work fine as the administrator user, the revision box is checked when I attempt to create a new blog entry and I submit it and a new revision is created. Unfortunately this is not the case when I am logged into my normal user account, it's as if the option is simply being ignored for normal users.

Is there some extra setting somewhere that I'm missing? I looked around and didn't see this submitted as a bug anywhere.

Thanks so much for any help you can provide in resolving this matter.

⋅ Categories: Drupal 5.x

Comments

sepeck’s picture

sepeck commented

Make sure your regular user account has View Revisions rights in Access Control.

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide

Flu’s picture

Flu commented

Thanks for the reply. I've confirmed that I have both revert and view revisions enabled for authenticated users, but it doesn't seem to make a difference. I even went so far as to wipe everything out, including my DB and starting again from scratch and I still have the same issue. Quite odd...

sepeck’s picture

sepeck commented

Have you actually made revisions to the content and submitted it? No revisions, no revision tab.

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide

Flu’s picture

Flu commented

Yep, sure have. Works fine when I'm logged in as the administrator, just doesn't happen when I'm logged into an authenticated user account.

Flu’s picture

Flu commented

So I guess I should file this as a bug? I checked the database itself and entries aren't being created in the node_revision table, so it's a creation issue of some sort and not a display issue.

Flu’s picture

Flu commented

The following patch (from here: http://drupal.org/node/114822) appears to resolve this issue for me:

Index: modules/node/node.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/node/node.module,v
retrieving revision 1.776.2.1
diff -u -p -r1.776.2.1 node.module
--- modules/node/node.module	29 Jan 2007 21:51:53 -0000	1.776.2.1
+++ modules/node/node.module	1 Feb 2007 01:39:21 -0000
@@ -1884,6 +1884,10 @@ function node_submit($node) {
   // saved values if the node exists, or force the defaults.
   if (!$access && $node->nid) {
     $saved_node = node_load($node->nid);
+    // workflow option 'revision' is not saved in the node table.
+    // thus it has to be loaded from the options. the other options are taken from the node
+    $node_options = variable_get('node_options_'. $node->type, array('status', 'promote'));
+    $saved_node->revision = in_array('revision', $node_options);
   }
   else {
     $node_options = variable_get('node_options_'. $node->type, array('status', 'promote'));
mugafuga’s picture

mugafuga commented

I tried to add the code to my node.module but it crashed after I saved it

which chunk of text goes where?
Whats up with all the +'s
do I need those?

Flu’s picture

Flu commented

The following page has instructions on applying .patch files:
http://drupal.org/node/60108

Basically, you would save the above code to a file, say revision_fix.patch in your root Drupal directory (where index.php is located) and then from the root directory type: patch -p0 < revision_fix.patch

Eliyahu’s picture

Eliyahu commented

Is there a way to get around this without the patch. Is there going to be an update?

Thank you