Hello,

I switched to iframe app at http://apps.facebook.com/shopping-mall , but the frames do not look very aesthetic :) Any tops on hiding them?

CommentFileSizeAuthor
#1 scrollbars FB80.97 KBdiscopig

Comments

discopig’s picture

discopig commented
StatusFileSize
new scrollbars FB80.97 KB

You should turn off the scrollbars option in your Developer App and can
and using the setSize() function in FB JavaScript SDK http://developers.facebook.com/docs/reference/javascript/FB.Canvas.setSize/

http://dl.dropbox.com/u/18075375/16.04.jpg

giorgio79’s picture

giorgio79 commented
Status: Active » Closed (fixed)

Lovely, thanks discopig.

giorgio79’s picture

giorgio79 commented
Title: iframe app borders » Call setSize when borders are turned off
Category: support » feature
Status: Closed (fixed) » Active

Lets make this a feature request, I think this javascript call should come from drupal for fb.

Dave Cohen’s picture

Dave Cohen commented
Component: Canvas Pages (iframe) » User is lazy
Status: Active » Fixed

Documentation helps. :)

http://drupal.org/node/923818

giorgio79’s picture

giorgio79 commented

Well, yes user is lazy for a reason :)

The module could simple call drupal_add_js so we dont have to modify theme files every time there is an update.

What do you think? :)

There is no reason for setSize sitting in body tag. It works perfectly fine for me in a block inside content area, under head.

giorgio79’s picture

giorgio79 commented
Status: Fixed » Active

Curious of opinions :)

Dave Cohen’s picture

Dave Cohen commented
Priority: Normal » Minor
Status: Active » Postponed (maintainer needs more info)

Submit a patch if you have a better way. Or explain what's wrong with the way it works now.

giorgio79’s picture

giorgio79 commented

The problem with modifying theme files is that when an upgrade comes to the theme, one has to always manually make the changes into the body over and over again. This makes updating themes a pain.

For now, I setup a simple block holding this js for myself, but the module could easily call drupal_add_js , and add this, even as inline javascript into head.

I dont have time for a patch now, leaving this open to someone who might have

Here is the doc on drupal_add_js that should be used IMHO :) http://api.drupal.org/api/drupal/includes--common.inc/function/drupal_ad...