Just installed Rep[lacement] Tags and turn off all the .tag modules (no need for them).

Went to the SiteWide Tag page and filled out the Tag and Replacement text boxes. I hit submit and it returns an error:

Error: Empty Field(s)

CommentFileSizeAuthor
#8 reptag-jquery-compatability.patch572 bytesdman

Comments

denney’s picture

Component: Code » Javascript / AJAX

Changing component. Disabling the JavaScript/AJAX in administration area fixes it.

Seems strange that the "Add", "Del" & "Edit" buttons still appear, although unusable.

profix898’s picture

Priority: Critical » Normal

You are running Drupal 5 with RepTag-5.x-1.1. Is this correct? What browser are you using? What PHP version? I just set up a clean Drupal 5 install and enabled reptag. AJAX/Javascript works fine for me. Tested on WinXP with Firefox 2, IE 7 and Opera 9.10.

denney’s picture

I'm running Drupal 5, Firefox 2, PHP 4.4.4 and MySQL 4.1.21.

I'm not quite sure what is causing these issues but I have a feeling it may be related to my install of jstools.

denney’s picture

Disregard that. It's not caused by jstools.

profix898’s picture

I'm not sure what I can do for you. I still cant reproduce. Looks like this issue is specific to your configuration, a conflicting module or javascript, a special server configuration, ... I dont know ... In case you were updating from an earlier version of Drupal/Reptag force a reload in FF to make sure the JS is loaded correctly. If you got any clue what is causing this issue, please let me know and I'll be happy to fix it. Maybe you can disable other contrib modules in your install and re-enable them one by one to find the conflicting one. Or does this issue occur on a clean install? Anyways I need more info ...

cowhead’s picture

I am having the same issue as Denny, and I have the same set up. The only other modules installed are cck, views, paging and tagadelic. Disabling them doesn't do the trick.

If I disable ajax support it works fine though.

profix898’s picture

I'm still unable to reproduce this bug, however I added a small patch to solve the 'seems strange that the "Add", "Del" & "Edit" buttons still appear, although unusable.' issue when javascript is disabled.

Does anyone have news on this issue? Is the bug still present in the latest version of reptag?

dman’s picture

StatusFileSize
new572 bytes

I believe it's a jquery version thing.
The built-in obj.id() and obj.name() went missing (I think) from jquery 1.0 to 1.1.

I'd upgraded jquery myself (with the two little hacks needed for Drupal) and tracked this error (buttons don't work) down in the FF debugger.

Attached is the patch that I needed to make things work again, using obj.attr('name') instead.
This is backwards-compatable, so should work right for both jquery1.0 and 1.1 versions.
It's regarded as being a slightly better way of doing things in jquery I guess, so there should be no objection (re the arguments about core compatability with jquery) ... just do it.

Patch also includes a fix for the incorrect behaviour in reptag_tag_attach() which was removing ALL submit buttons, not just its own :-)
I thought my problem may have been a theme fault, but could not use 'switchtheme' as reptag_helper.js had broken it!

Please test on an older, non-updated site to see things still work.

(Note, this may be a totally different error from the one reported here - but I suspect it's the same problem)

vizechef’s picture

Der Fehler "Empty Fields ..." ist leider immer noch da !!
Nutze WinXP,XAMPP 1.6.3 mit PHP4, Firefox, Drupal 5.2.
Wäre super, wenn Du Dir das nochmal anschauen und bald eine Lösung finden könntest.

profix898’s picture

In English, please! ;) I'm still unable to reproduce. Have you tried dman's patch above? Its the only hint I have. I'm quite busy atm updating my modules, but I will add the patch to the next bugfix release. However the D6 version will no longer use the custom JS callbacks to add/delete/modify tags, but jforms plugin to submit the whole form. This will hopefully solve the problem.

(Es gibt einen neuen IRC channel #drupal.de. Vielleicht schaust Du dort auch mal vorbei!? Wir suchen noch deutschsprachige Drupaler. Ansonsten auf deutsch jederzeit per eMail.)

profix898’s picture

Status: Active » Reviewed & tested by the community
duaelfr’s picture

Status: Reviewed & tested by the community » Closed (won't fix)

This version of Rep[lacement]Tags is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.