Will we be seeing HeadJS integration with Advanced CSS/JS Agg? Would be cool! http://drupal.org/project/headjs

Comments

alexweber’s picture

Status: Active » Needs review

I just released the first stable version of headjs and made sure it's 100% compatible with advagg. No modifications to advagg are needed!

Could you please add it to the project's description as being compatible?

Thanks!!

-- Alex

mikeytown2’s picture

Title: HeadJS integration » HeadJS/AdvAgg integration
Project: Advanced CSS/JS Aggregation » HeadJS
Status: Needs review » Needs work

Awesome! Glad this works out the the box. One thing you could do is checkout LABjs's advagg functions that are called. You can skip the _headjs_get_scripts function by setting a custom js render function for advagg. See LABjs code for details.
hook_advagg_js_pre_alter
labjs_advagg_js_builder
#1087056: LABjs - Drupal.behaviors/Drupal.settings issue - Fixes this bug if using advagg; issue has to do with regex matching a large js settings array.

alexweber’s picture

Sweet! Thanks Mike, I'll check it out and get it done in the next few days!

alexweber’s picture

Assigned: Unassigned » alexweber
Status: Needs work » Active
alexweber’s picture

Status: Active » Needs review

implemented in dev release and new beta, both should be available in a couple hours!

alexweber’s picture

Assigned: alexweber » Unassigned
alexweber’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Closed (fixed)

closing due to 2 weeks of inactivity, if anyone experiences this please re-open, thanks!

mikeytown2’s picture

Status: Closed (fixed) » Active
alexweber’s picture

Thanks Mike!

Gonna check this out.

alexweber’s picture

Status: Active » Closed (fixed)

another issue has already been opened for this