Image type is already part of a relationship [#1130450]

When trying to create a new relationship you get an error message of "x is already part of a relationship"

Why is that an image type can only be assigned to one gallery type? We have a content type for Events and for Articles which both would like to use the same Image content type with its taxonomy and various settings/cck fields.

It seems it is only a user interface problem as you can create a similar row in the node_gallery_relationships table and all works well. Perhaps this requirement should be lifted and not report an error.

Comments

Comment #1

justintime commented 21 April 2011 at 02:50

Have you ran with this setup for awhile? I was the one that originally coded that in, but I don't think I had a reason at the time. I think I just anticipated needing that to be distinct. Looking through the current code, I don't see any reason for this limitation. If you test it for awhile and don't have any issues, I'd be open to removing the restriction.

Comment #2

davidarthur commented 28 April 2011 at 21:10

Yes It's been running for a while now, I'd say it was safe to remove the restriction. It's always been supported since v2 at least anyway...

Comment #3

justintime commented 18 May 2011 at 21:50

Status:

Active

» Closed (works as designed)

Now I remember why.

Search the codebase for all occurrences of 'node_gallery_get_relationship(NULL,'. See all those results? Those are cases where we fetch the relationship (ie, the gallery type, the image type, and all settings) based upon the image type. We're essentially using the image type as a unique key.

In the case where you've inserted multiple rows into the database manually, only the last row returned from the DB will ever be used.