I think the tracker code should not appear on the following list of regex urls:

admin
admin/*
batch
node/add*
node/*/*
user/*/*

CommentFileSizeAuthor
#3 pardot.exclude_pages.patch1016 bytesaaronott

Comments

jonwhitcraft’s picture

Here is a node explaing which pages to use: http://drupal.org/node/34970

neclimdul’s picture

That's probably a good idea. I'll have to think about it a little so we don't cause any regressions in the other code but the admin should be able to limit where the tracking code is being added.

aaronott’s picture

StatusFileSize
new1016 bytes

So I needed to exclude some pages on a d6 site as well, so I "borrowed" some code from the securepages module to add a quick check.

The patch does not include any administration pages but since it does a variable_get to get the pages to skip, it would be very easy to build an admin interface to allow for the editing of this list.

misc’s picture

Have code for this for the drupal 7 version (over here: https://bitbucket.org/wroxbox/pardot/pull-request/10/added-visibilty-set...) - I could backport it when we have started tested the drupal 7 patch: https://drupal.org/node/1162688#comment-7619297

misc’s picture

Status: Active » Needs review
neclimdul’s picture

Status: Needs review » Needs work

Lets backport the more complete implementation from the 7 port.

drupalninja99’s picture

How much work would it take? Are you saying backport everything or just the page visibility functionality?

neclimdul’s picture

I was just referring to the page visibility functionality. Its a better implementation of this functionality and already solved on d7

drupalninja99’s picture

Issue summary: View changes
Status: Needs work » Closed (won't fix)

Going to close. With D8 on the doorstep I think D6 updates are going to have to be bugs only at this point. If you would like to submit a patch that would be fine, otherwise I have to focus on 7x issues.