String is not wrapped with t() [#1131900]

Posted by sandino on April 19, 2011 at 10:19am

3 followers

Issue Summary

In theme.inc string 134 has item that is not wrapped in t()

<?php
    return '<span class="topic-pager">(Page: ' . implode(", ", $topic_pager->initial_pages) . $last_page . ')</span>';
?>

I changed it to

<?php
    return '<span class="topic-pager">('.t('Page').': ' . implode(", ", $topic_pager->initial_pages) . $last_page . ')</span>';
?>

and it can be translated now.

Posted by sandino on April 19, 2011 at 12:54pm

Title:

String not translated

» String is not wrapped with t()

Posted by mcdruid on June 19, 2011 at 12:45am

Status:

active

» closed (fixed)

Thanks sandino.

For future reference, it's better to attach a patch to the issue with any code fixes.

This is a very minor thing, but Drupal coding standards have a space on both sides of the dot when concatenating strings: http://drupal.org/coding-standards#concat

Committed to 6.x-2.x branch.

Attachment	Size
fix_string_not_wrapped_in_t-1131900.patch	554 bytes

Posted by mcdruid on June 23, 2011 at 5:43pm

Status:

closed (fixed)

» fixed

oops - realised I should have been setting issues to "fixed" rather than "closed (fixed)"

Posted by System Message on July 7, 2011 at 5:51pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.