The definition of the $modules @param is "An array of the enabled modules."
This makes sense, but it also makes you think for a second. "Does it mean all the modules currently enabled? Or just the modules being enabled in the current request?"
Of course, if you had to guess, you'd probably guess correctly. But let's eliminate the guesswork.
Proposed wording: "An array of the modules being enabled." Patch forthcoming.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1132364-5.patch | 1.26 KB | David_Rothstein |
| #1 | 1132364-hook_modules_enabled_less_ambiguous_docs-D8.patch | 425 bytes | crookednumber |
Comments
Comment #1
crookednumber commentedPatch.
Comment #2
jhodgdonLooks like a good change to me, thanks! 7.x and 8.x please.
Comment #3
dries commentedThanks CrookedNumber. Committed to 7.x and 8.x.
Comment #5
David_Rothstein commentedI think the new wording here is a bit misleading, since it says the modules are "being enabled" but actually they were already fully enabled before this hook is ever called.
Also, any wording change we make to hook_modules_enabled() should also be made to hook_modules_disabled(), hook_modules_installed(), etc...
Attached patch addresses both of those issues.
Comment #6
jhodgdonOK. I have no objection to the wording change in this patch. Let's get it into 8.x and 7.x.
Comment #7
crookednumber commentedAgreed. Thanks for the second look, David.
Comment #8
catch.
Comment #9
dries commentedCommitted to 7.x and 8.x.
(Working from the road so can't review big complex issues right now -- picking away some smaller patches that are unlikely to break bigger patches.)